This repository was archived by the owner on Nov 6, 2020. It is now read-only.
[stable]: backport #10984#11212
Merged
seunlanlege merged 2 commits intov2.5.10-stablefrom Nov 8, 2019
Merged
Conversation
Member
seunlanlege
commented
Oct 28, 2019
seunlanlege
commented
- Add a new line after writing block to hex file. (Add new line after writing block to hex file. #10984)
ordian
added
the
A8-backport 🕸
seunlanlege
force-pushed
the
seun-backport-10984
branch
from
d7d6ae0 to
ea7b318
Compare
Collaborator
|
looks good to me but I wonder if it's the right branch? @s3krit should it be against the upcoming release, |
Contributor
|
That doesn't matter @dvdplm Question I have, doesn't we need this in Beta too? |
soc1c
approved these changes
Nov 5, 2019
Contributor
|
Changed the base for #11239 Could you resolve conflicts and merge? |
seunlanlege
force-pushed
the
seun-backport-10984
branch
from
ea7b318 to
7544dfb
Compare
This was referenced Nov 5, 2019
seunlanlege
force-pushed
the
seun-backport-10984
branch
from
1def0f7 to
168ff56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.