-
Notifications
You must be signed in to change notification settings - Fork 7
Faking availableReplicas to enable usage of the gateway UI #5
Faking availableReplicas to enable usage of the gateway UI #5
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. |
928f288
to
0cf3408
Compare
You have 4 commits now, so do: Alex |
Signed-off-by: Jonathan Gnagy <[email protected]>
Signed-off-by: Jonathan Gnagy <[email protected]>
0cf3408
to
3fdbe80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jgnagy for your contribution. This change seems reasonable since currently faas-rancher and the new gateway can't use the gateway UI.
Few things I want to make sure:
- How did you update the vendor file? This repo uses rancher/trash for vendors. (not
dep
IIRC). - Could you provided a little more information about how you tested this?
@@ -85,6 +85,8 @@ func MakeReplicaReader(client rancher.BridgeClient) VarsHandler { | |||
return | |||
} | |||
|
|||
found.AvailableReplicas = found.Replicas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. But could you leave a comment about faking the information? Thanks ;)
Let's switch to dep Ken? |
I'm not against that and that's a reasonable change, too. |
#7 is a much better approach. This PR is no longer necessary. |
I'm no Go developer so feel free to make fun of anything I did wrong here. I was able to run
make build
and it seems to have succeeded but I wasn't sure how to run unit tests.@alexellis and @kenfdev please let me know if I need to do this differently.