Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Faking availableReplicas to enable usage of the gateway UI #5

Closed

Conversation

jgnagy
Copy link

@jgnagy jgnagy commented Jan 5, 2019

I'm no Go developer so feel free to make fun of anything I did wrong here. I was able to run make build and it seems to have succeeded but I wasn't sure how to run unit tests.

@alexellis and @kenfdev please let me know if I need to do this differently.

@derek derek bot added the new-contributor label Jan 5, 2019
@derek
Copy link

derek bot commented Jan 5, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@derek derek bot added the no-dco label Jan 5, 2019
@jgnagy jgnagy force-pushed the feature/fake-available-replicas branch from 928f288 to 0cf3408 Compare January 5, 2019 03:01
@alexellis
Copy link
Member

You have 4 commits now, so do: git reset HEAD~4 then git add and commit -s followed by a force push. That should sort things out.

Alex

@jgnagy jgnagy force-pushed the feature/fake-available-replicas branch from 0cf3408 to 3fdbe80 Compare January 5, 2019 18:49
@derek derek bot removed the no-dco label Jan 5, 2019
@kenfdev kenfdev self-requested a review January 12, 2019 14:09
@kenfdev kenfdev changed the title Adding a horrible hack to fake availableReplicas Faking availableReplicas to enable usage of the gateway UI Jan 12, 2019
Copy link
Member

@kenfdev kenfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jgnagy for your contribution. This change seems reasonable since currently faas-rancher and the new gateway can't use the gateway UI.

Few things I want to make sure:

  • How did you update the vendor file? This repo uses rancher/trash for vendors. (not dep IIRC).
  • Could you provided a little more information about how you tested this?

@@ -85,6 +85,8 @@ func MakeReplicaReader(client rancher.BridgeClient) VarsHandler {
return
}

found.AvailableReplicas = found.Replicas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. But could you leave a comment about faking the information? Thanks ;)

@alexellis
Copy link
Member

Let's switch to dep Ken?

@kenfdev
Copy link
Member

kenfdev commented Jan 12, 2019

Let's switch to dep Ken?

I'm not against that and that's a reasonable change, too.
Unfortunately, I don't have the time to do it myself but if @jgnagy or someone in the community could take it, I'm more than happy to review it.

@jgnagy
Copy link
Author

jgnagy commented Jan 25, 2019

#7 is a much better approach. This PR is no longer necessary.

@jgnagy jgnagy closed this Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants