Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Feature which enable Connector to leverage Responses #4

Closed
wants to merge 3 commits into from
Closed

Implemented Feature which enable Connector to leverage Responses #4

wants to merge 3 commits into from

Commits on Jan 20, 2019

  1. Implemented Feature which enable Connector to leverage Responses 

    Signed-off-by: Simon Pelczer <[email protected]>
    @Templum
    Templum committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    fc0c5c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Adjusted Code based on received feedback 

    * Using a Struct for return value for performInvocation
* No longer aborting requests on first error
* performInvocation is now method of Invoker
* Handled NewRequest error, altough this only happens when miss configured
Signed-off-by: Simon Pelczer <[email protected]>
    @Templum
    Templum committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    df64b7d View commit details
    Browse the repository at this point in the history

  2. Adjusted Tests 

    * They now check that an failing function wont abort invocations
* They check that no invocation is performed for invalid messages
* They check error is only set when an error occurred
Signed-off-by: Simon Pelczer <[email protected]>
    @Templum
    Templum committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d8420ed View commit details
    Browse the repository at this point in the history