Compilation flags for ARM64 on Mac #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
tobil4sk
reviewed
Mar 1, 2023
| <file name="${NATIVE_TOOLKIT_PATH}/pixman/src/pixman-timer.c" /> | ||
| <file name="${NATIVE_TOOLKIT_PATH}/pixman/src/pixman-trap.c" /> | ||
| <file name="${NATIVE_TOOLKIT_PATH}/pixman/src/pixman-utils.c" /> | ||
| <file name="${NATIVE_TOOLKIT_PATH}/pixman/src/pixman-x86.c" /> | ||
| <file name="${NATIVE_TOOLKIT_PATH}/pixman/src/pixman-x86.c" if="windows || mac || linux" unless="rpi || HXCPP_ARM64"/> |
There was a problem hiding this comment.
Not including pixman-x86.c and pixman-mips.c causes linking errors:
"__pixman_mips_get_implementations", referenced from:
__pixman_choose_implementation in 2ec37e17_pixman-implementation.o
"__pixman_x86_get_implementations", referenced from:
__pixman_choose_implementation in 2ec37e17_pixman-implementation.o
Both pixman-x86.c and pixman-mips.c should be built also on arm64 platforms, otherwise lime.ndll will not link properly. Instead, the config.h needs to be adjusted to fix compilation. See: #2
There was a problem hiding this comment.
Thanks for taking up this issue ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compilation flags for ARM64