feat: adding webhooks functionality #619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Stale pull request message |
zhouzhuojie
reviewed
Aug 6, 2025
| Description string `gorm:"type:text"` | ||
| Events string `gorm:"type:text"` // Comma-separated list of events to trigger on | ||
| Secret string `gorm:"type:text"` // Optional secret for webhook signature | ||
| Enabled bool `gorm:"default:true"` |
There was a problem hiding this comment.
please add an index here, since the query uses enabled = true
zhouzhuojie
reviewed
Aug 6, 2025
zhouzhuojie
reviewed
Aug 6, 2025
| } | ||
| if params.Body.EntityType != nil { | ||
| et := *params.Body.EntityType | ||
| if err := entity.CreateFlagEntityType(tx, et); err != nil { |
There was a problem hiding this comment.
looks like this logic got removed?
zhouzhuojie
reviewed
Aug 6, 2025
| @@ -1,22 +1,28 @@ | |||
| package handler | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
many of the trigger logic seems repetitive, do you think it can be done with refactor much of this logic into GORM model hooks (BeforeCreate, AfterCreate, BeforeUpdate, AfterUpdate, BeforeDelete, AfterDelete)? This would centralize the webhook logic within the model definitions, making the CRUD handlers cleaner and reducing the risk of missing a webhook trigger in future code changes.
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Global Webhook Support
Description
This PR adds support for global webhooks in Flagr, allowing users to receive notifications for system events. The implementation includes:
Webhookentity for storing webhook configurationsWebhookEvententity for tracking webhook delivery statusMotivation and Context
Currently, Flagr lacks a way to notify external systems about changes to flags, segments, variants, and other entities. This makes it difficult to integrate Flagr with other systems that need to react to these changes. The webhook system provides a flexible way to notify external systems about these events.
How Has This Been Tested?
Types of changes
Checklist: