Ensure shipment gets updated when an order is updated #12954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rioug
force-pushed
the
fix-shipment-not-updated
branch
from
9d02c87
to
d380a9d
Compare
`Spree::OrderContents#update_or_create` is used to update the cart when on the /shop page. If you start an order and proceed to the "Order summary" step, and then decide to update your order by using the shop link next to the cart, such update wouldn't update the shipment. This result in the order page in the backoffice displaying the wrong data, and more importantly, in the stock not being updated. So now we ensure shipment will be updated, which result in the checkout flow being restarted, thus making sure the shipment is updated.
rioug
force-pushed
the
fix-shipment-not-updated
branch
from
d380a9d
to
58ef10f
Compare
dacook
requested changes
Nov 13, 2024
| @@ -38,6 +38,7 @@ def update_or_create(variant, attributes) | |||
| line_item.price = variant.price | |||
| order.line_items << line_item | |||
| end | |||
| update_shipment | |||
There was a problem hiding this comment.
Is it relevant for both create and update? I thought it might only need to be called on update.
|
|
||
| subject.update_or_create(variant, { quantity: 2, max_quantity: 3 }) | ||
| end | ||
|
|
There was a problem hiding this comment.
Looks like this tests creating mode, but not updating an existing line item (Which I think is what it should be testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I came across this while looking at #12907
Given an order up to "Order Summary" step, if a customer then update the cart by going back to the shop page via the link next to the cart, the order shipment won't be updated.
It results in :
To fix this, we make sure we delete existing shipment and restart the checkout flow.
Order confirmation started with 2 potatoes test , was updated to 4 potatoes test and 3 potatoes
Admin screen showing only the original items/quantity , 2 potatoes test
Potatoes test stock reduced from 50 to 48, and Potatoes stock stayed at 20
What should we test?
As an enterprise manager:
As a customer
--> the order should have the correct items and quantity
As an enterprise manager
--> The items should all be there and have the correct quantity
--> verify that the stock of the products in the order have been decreased by the correct number
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.