Skip to content

Commit

Permalink
Merge pull request #715 from openforcefield/v0.3.3-release-notes
Browse files Browse the repository at this point in the history
Add v0.3.3 release notes
  • Loading branch information
mattwthompson authored May 8, 2023
2 parents 40c8027 + fa85693 commit 94e4a6f
Show file tree
Hide file tree
Showing 14 changed files with 38 additions and 856 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ repos:
hooks:
- id: markdownlint
exclude: .github
args: ["--disable", "MD013", "MD033", "MD024", "MD046", "--"]
args: ["--disable", "MD013", "MD033", "MD024", "MD046", "--ignore", "docs/using/experimental.md", "--"]
- repo: https://github.com/nbQA-dev/nbQA
rev: 1.7.0
hooks:
Expand Down
13 changes: 0 additions & 13 deletions devtools/conda-envs/docs_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,11 @@ dependencies:
- openff-toolkit-base >=0.13
- openff-models
- openmm >=7.6
- pint
- unyt
- mbuild
- foyer >=0.11.3
- mdtraj
- intermol
- jax
- nbval
- nglview
- ipywidgets >7,<8 # https://github.com/nglviewer/nglview/issues/1032
- mdanalysis
- gromacs >=2021=nompi*
- lammps
# https://github.com/conda-forge/quippy-feedstock/issues/15
- panedr
- mypy =1.2
- typing-extensions
- types-setuptools
- pandas-stubs >=1.2.0.56
# readthedocs dependencies
- myst-parser
Expand Down
7 changes: 1 addition & 6 deletions devtools/conda-envs/examples_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,15 @@ dependencies:
# OpenFF stack
- openff-toolkit >=0.13
- openff-forcefields >=2023.05
- openff-models >=0.0.4
# Optional features
- jax
- unyt
- mbuild
- foyer >=0.11.3
# Examples
- jax
- mdtraj
- pdbfixer
- intermol
- nglview
- ipywidgets >7,<8 # https://github.com/nglviewer/nglview/issues/1032
- openeye-toolkits
- pytest
- nbval
Expand All @@ -33,5 +30,3 @@ dependencies:
# Drivers
- gromacs >=2021=nompi*
- lammps
# https://github.com/conda-forge/quippy-feedstock/issues/15
- panedr
20 changes: 18 additions & 2 deletions docs/releasehistory.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,28 @@ Releases follow versioning as described in

Please note that all releases prior to a version 1.0.0 are considered pre-releases and many API changes will come before a stable release.

## Current development
## 0.3.3 - 2023-05-08

* #703 Clarifies the experimental state of some features, which require opt-in to use.

### Behavior changes

* #706 Updates `pack_box` to return a `Topology`.
* #716 Removes InterMol and ParmEd conversions, which were untested and not part of the public API.

### Bugfixes

* #705 Fixes #693 in which 1-4 vdW interactions were not scaled when using `Interchange.to_openmm(combine_nonbonded_forces=False)`
* #702 Fixes #701 in which `Interchange` was needlessly re-exported in the high-level module.

### Documentation improvements

* #673 Adds a vectorized representation example.
* #703 Adds a section to the user guide on accessing experimental functionality.
* #706 Updates the mixed solvent example.
* #708 Updates the protein-ligand example.
* #708 Updates the ligand-in-water example.

## 0.3.2 - 2023-05-02

### Behavior changes
Expand Down Expand Up @@ -96,7 +112,7 @@ Please note that all releases prior to a version 1.0.0 are considered pre-releas
* #614 Adds support for GBSA parameters in SMIRNOFF force fields.
* #586 #591 #605 #609 #613 Support custom SMIRNOFF sections with OpenMM.

### Documentation
### Documentation improvements

* #634 Improves documentation for SMIRNOFF plugins.
* #610 Adds duplicate documentation on how to covert to OpenMM-styled unit/quantity objects.
Expand Down
2 changes: 1 addition & 1 deletion docs/using/experimental.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ $ INTERCHANGE_EXPERIMENTAL=1 jupyter-notbook my_notebook.ipynb

or, with cloud services like Google Colab and Binder, use the [`%env`](https://ipython.readthedocs.io/en/stable/interactive/magics.html#magic-env) magic command:

```jupyter
```
%env INTERCHANGE_EXPERIMENTAL=1
```

Expand Down
5 changes: 5 additions & 0 deletions openff/interchange/__init__.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
"""A project (and object) for storing, manipulating, and converting molecular mechanics data."""
import importlib
from types import ModuleType
from typing import TYPE_CHECKING

from openff.interchange._version import get_versions

if TYPE_CHECKING:
# Type checkers can't see lazy-imported objects
from openff.interchange.components.interchange import Interchange

# Handle versioneer
versions = get_versions()
__version__ = versions["version"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@


class TestAmber(_BaseTest):
@pytest.mark.slow()
@pytest.mark.skip(reason="Need replacement route to reference positions")
def test_inpcrd(self, sage):
mol = Molecule.from_smiles(10 * "C")
mol.name = "HPER"
Expand All @@ -26,6 +26,7 @@ def test_inpcrd(self, sage):
out.positions = unit.nanometer * np.round(out.positions.m_as(unit.nanometer), 5)

out.to_inpcrd("internal.inpcrd")
# This method no longer exists
out._to_parmed().save("parmed.inpcrd")

coords1 = parmed.load_file("internal.inpcrd").coordinates
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def parse_mdp(file: str) -> dict[str, str]:

def parse_sander(file: str) -> dict[str, Union[dict, str]]:
"""Naively parse (sections of) a sander input file into a dict structure."""
options = dict()
options: dict[str, Union[dict, str]] = dict()
current_level = options

with open(file) as f:
Expand All @@ -79,7 +79,7 @@ def parse_sander(file: str) -> dict[str, Union[dict, str]]:
if line.startswith("&"):
current_section = line[1:]
current_level[current_section] = dict()
current_level = current_level[current_section]
current_level = current_level[current_section] # type: ignore[assignment]
continue

if "=" in line:
Expand Down
22 changes: 0 additions & 22 deletions openff/interchange/components/interchange.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,11 +374,6 @@ def to_prmtop(self, file_path: Union[Path, str], writer="internal"):

to_prmtop(self, file_path)

elif writer == "parmed":
from openff.interchange.interop._external import ParmEdWrapper

ParmEdWrapper().to_file(self, file_path)

else:
raise UnsupportedExportError

Expand Down Expand Up @@ -414,26 +409,9 @@ def to_inpcrd(self, file_path: Union[Path, str], writer="internal"):

to_inpcrd(self, file_path)

elif writer == "parmed":
from openff.interchange.interop._external import ParmEdWrapper

ParmEdWrapper().to_file(self, file_path)

else:
raise UnsupportedExportError

def _to_parmed(self):
"""Export this Interchange to a ParmEd Structure."""
from openff.interchange.interop._parmed import _to_parmed

return _to_parmed(self)

@classmethod
def _from_parmed(cls, structure):
from openff.interchange.interop._parmed import _from_parmed

return _from_parmed(cls, structure)

@classmethod
@requires_package("foyer")
def from_foyer(
Expand Down
54 changes: 0 additions & 54 deletions openff/interchange/interop/_external.py

This file was deleted.

Loading

0 comments on commit 94e4a6f

Please sign in to comment.