-
Notifications
You must be signed in to change notification settings - Fork 655
Feature/troop breakdown visualization with missions #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
binmogit
wants to merge
22
commits into
openfrontio:main
Choose a base branch
from
binmogit:feature/troop-breakdown-visualization-with-missions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+243
−8
Open
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
70314d0
Add visual troop capacity breakdown bar
binmogit d6f561f
Fix troop breakdown bar rendering
binmogit ab45db9
Rename variables for clarity: _territoryMax/_cityMax → _territoryCapa…
binmogit 154a26f
Refactor: extract base capacity methods to avoid formula duplication
binmogit 0763b09
Add error handling and accessibility to troop breakdown bar
binmogit dbd2c87
Reset _maxTroops in error handler for consistent state
binmogit 9695ee7
Add troops on mission visual indicator to capacity bar
binmogit b44eca2
Merge main into feature/troops-on-mission
binmogit dfc90ae
Remove tooltip from troop capacity bar for simplicity
binmogit fe15279
Use totalUnitLevels() helper method in baseCityCapacity()
binmogit d23e688
Refactor: Calculate troops on mission directly from PlayerView data
binmogit 86c853d
Apply code review optimizations
binmogit 0b556cb
Apply micro-optimizations and remove verbose comments
binmogit 0c9257a
Remove unnecessary comments from ControlPanel
binmogit 8608dfc
Refactor troop capacity: rename methods and add estimation helpers
binmogit fb18014
Merge upstream/main into feature/troop-breakdown-visualization-with-m…
binmogit 0e4727c
docs: add JSDoc for fork-introduced symbols
binmogit 67b92c1
Fix capacity estimates for non-human players.
binmogit 098ddca
Merge branch 'main' into feature/troop-breakdown-visualization-with-m…
binmogit 42698de
Merge branch 'main' into feature/troop-breakdown-visualization-with-m…
binmogit bbe0457
More accurate doc
binmogit c17c037
Refactor: extract estimateTroopSources helper for estimatedTroopsTerr…
binmogit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.