Avoid error when $id is not string

opengeospatial · Dec 9, 2023 · ac3a96e · ac3a96e
1 parent fa23d8d
commit ac3a96e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/ogc/bblocks/util.py b/ogc/bblocks/util.py
@@ -766,7 +766,8 @@ def apply_fixes(parent):
             if add_nullable:
                 parent['nullable'] = True
 
-    def walk(subschema, schema_id: str | Path, is_properties: bool = False) -> tuple[dict, str, str | Path]:
+    def walk(subschema: dict | list, schema_id: str | Path, is_properties: bool = False) \
+            -> tuple[dict | list, str | None, str | Path]:
         schema_version = None
         if isinstance(subschema, list):
             for item in subschema:
@@ -778,7 +779,7 @@ def walk(subschema, schema_id: str | Path, is_properties: bool = False) -> tuple
 
             schema_version = subschema.pop('$schema', None)
             schema_id = subschema.pop('$id', schema_id)
-            if isinstance(subschema.get('$ref'), str):
+            if isinstance(schema_id, str) and isinstance(subschema.get('$ref'), str):
 
                 ref = f"{schema_url}#/x-defs/{get_ref_mapping(schema_id, subschema.pop('$ref'))}"