build: release v6.70.0

[wanlingt]

New

• fix: supply empty object when snapshot script has not completely migrated #6622
• feat: payment by products #6301
• chore: Added react dev inspector #6611
• feat: filter out API details from user object #6588
• docs: update feature section of README #6603
• chore: remove angular deps #6602
• chore: remove customMin and customMax virtuals #6596
• build: merge v6.69.0 into develop #6601
• build: release v6.69.0 #6600
• chore: bump version to v6.70.0 b7e2760

Dependencies

• fix(deps): bump libphonenumber-js from 1.10.40 to 1.10.41 in /shared #6616
• fix(deps): bump libphonenumber-js from 1.10.39 to 1.10.40 in /shared #6614
• fix(deps): bump type-fest from 4.1.0 to 4.2.0 in /shared #6610
• fix(deps): bump import-in-the-middle from 1.3.4 to 1.4.2 #6609
• fix(deps): bump validator from 13.9.0 to 13.11.0 in /shared #6605
• fix(deps): bump libphonenumber-js from 1.10.38 to 1.10.39 in /shared #6594

Dev-Dependencies

• chore(deps-dev): bump @types/lodash from 4.14.196 to 4.14.197 in /shared #6612

Tests

fix: supply empty object when snapshot script has not completely migrated #6622

@wanlingt

• Make a payment
• Find your payment document in the DB, rename payment.payment_fields_snapshot to something else
• On the Dedicated Payment Page and observe that the page doesn't crash (product/service will be empty)

feat: payment by products #6301

Regression Tests @wanlingt

Fixed payments form should work as usual
As a form admin with fixed payment form

• Update to description, name, amount works without error

As responder on fixed payment form

• Able to make payment without error
• Check that the proof of payment reflects the correct product and amount.

Variable payments form should work as usual
As a form admin with variable payment form

• Update to description, name, min, max, amount works without error

As responder on variable payment form

• Able to set an amount within range without error
• Able to make payment without error
• Check that the proof of payment reflects the correct product and amount.

Storage Form filling (due to refactors on encrypt-submissions) @wanlingt

• Able to submit a storage form with captcha disabled
• Able to submit a storage form with captcha enabled
• Unable to submit a storage form that's closed

New Feature Test @LinHuiqing

New Payment by Products form without connected account
As a form admin

• Select payments by product as payment type
• Ensure that name, description, add products, and save button are disabled and not interactable

New Payment by Products form with a stripe account
Creating new product

• Create new payments by product payment form
• Add a product with name "Nameless", description "Nondescript", amount "300", multiple qty "Off"
• Check that <PaymentPreview /> has "Nameless", "Nondescript", and price $300.00
  • Checkbox should be rendered as a <Radio />
• Check that <ProductItem /> has "Nameless", and price $300.00
• Edit the created product to have a different name, and save
• Edit the created product to have amount of 123456789, the item should show an error prompting that amount should be below $200,000
• Set the amount to 100

Note that Product Item is saved on modal saving, instead of saving on payment panel.

• Submit a payment by products form with 1 qty x 1 product. Check that the proof of payment reflects the correct quantity, item amount and final amount
• Submit a payment by products form with >1 qty x >1 product. Check that the proof of payment reflects the correct quantity, item amount and final amount

chore: Added react dev inspector #6611

@wanlingt

• Start FormSG locally and press "Control + Shift + C". Click any component and it should redirect you to the corresponding LOC in vs code.

feat: filter out API details from user object #6588

@KenLSM

• Update a user with the apiToken property ({keyHash: .., createdAt:.., lastUsedAt:.. }). Check that none of the following queries returns the apiToken property with the user object:
  • GET /api/v3/admin/forms - visit admin form dashboard page
  • POST /api/v3/auth/otp/verify - log out and log in again
  • GET /api/v3/user - visit admin form dashboard page
  • POST /user/contact/otp/verify - verify contact OTP

chore: remove customMin and customMax virtuals #6596

@wanlingt

• For each combination of (min/max/exact) for (number / short text / long text) field:
  • Create a field with the validation. This should work.
  • Modify the validation options. This should work.
  • Attempt to submit a form with a response not satisfying the validation option. This should trigger an error on the frontend.
  • Attempt to submit a form with a response satisfying the validation option. This should work.

chore: bump version to v6.70.0 b7e2760

Deploy Notes

New scripts:

• set-payment-fields-snapshot.js : This script adds the payment_fields_snapshot field to the payments collection and sets the field as the form document's payment_field for all existing documents.

New dependencies:

• dependency : React Dev Inspector

New dev dependencies:

• dependency : React Dev Inspector

[LinHuiqing]

For #6301:

Ensure that name, description, add products, and save button are disabled and not interactable

If I were to add products prior to disconnecting the stripe account, the products are still there and I can click the buttons as usual. Just that I can't save properly as an error message it thrown by the backend.

[KenLSM]

For #6301:

Ensure that name, description, add products, and save button are disabled and not interactable

If I were to add products prior to disconnecting the stripe account, the products are still there and I can click the buttons as usual. Just that I can't save properly as an error message it thrown by the backend.

:'(, I'll handle that in another ticket.

I suppose it is not blocking.

[LinHuiqing]

Regarding the same PR #6301 on payments by product, spotted another bug where admins will not be able to save payment amounts between $2020.20 and $200,000. This has been decided to be non-blocking and will be fixed in the next release (tracked with this ticket).