feat: add publish and workflow feedback triggers#9689
Open
bookwormsuf wants to merge 1 commit into
Open
Conversation
Set admin feedback eligibility when a form goes public or when 2+ workflow steps are completed. Adds isStepCompleted utility for determining workflow step completion across all WorkflowTypes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
13 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Part 4 of admin satisfaction rating split (see #9683, #9684, #9688). Adds two new trigger points that tell the zustand feedback store when a user has done enough work to warrant a satisfaction prompt.
Solution
Two trigger points call
setEligible()on the admin feedback store:'publish'feedback prompt.'workflow'feedback prompt.An
isStepCompletedutility determines whether a workflow step has all required fields based on itsWorkflowType(Static/Dynamic/Conditional). 4 unit tests cover one per workflow type + the empty-edit guard.Breaking Changes
No — backwards compatible. Trigger points are gated behind the
5star-admin-ratingfeature flag (PR 1).Tests
TC1: Publish triggers feedback
window._growthbook.setForcedFeatures(new Map([['5star-admin-rating', true]]))TC2: Workflow triggers feedback
TC3: Incomplete workflow does not trigger
🤖 Generated with Claude Code