fix(frontend): defer form title save to cta click in design drawer#9772
Open
rickysurya wants to merge 1 commit into
Open
fix(frontend): defer form title save to cta click in design drawer#9772rickysurya wants to merge 1 commit into
rickysurya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every other field in that drawer only saves when "Save design" is clicked, but the form name was able to save immediately on blur which created inconsistencies with the rest of settings in the drawer
Closes #9350
Solution
Moved the form title into the local frontend draft layer. The live preview window now listens to this local store draft. The actual save is now deferred until the user explicitly clicks the "Save design" CTA button.
Breaking Changes