feat(logic): click-to-edit logic cards (2/2)

[bookwormsuf]

Problem

Logic cards lock every other card while one is open — you have to Save or Cancel before you can touch another card. Part 1 (#9781) fixed this for workflow step cards; this PR mirrors the same behaviour onto logic cards.

Stacked on #9781 — please review/merge that first. Base retargets to develop once Part 1 lands.

Closes FRM-2491.

Solution

Behind the existing editable-cards-mrf-logic flag (default off), the whole logic card becomes clickable with a hover affordance, and clicking another card auto-saves the open one and switches to it. The auto-save runs through the same validated submit path as the Save button, so incomplete data blocks the switch and surfaces validation errors instead of silently losing work.

Implementation mirrors Part 1's workflow store and components: a pendingSwitchTo field plus requestSwitchTo / cancelPendingSwitch / completeSave on the logic store, an auto-save useEffect that fires when another card is clicked, and onSuccess: completeSave / onError: cancelPendingSwitch on the save mutations. Flag off = previous behaviour (cards locked while one is open, pencil-only edit).

One logic-specific difference from Part 1: logic's EditLogicBlock is shared by both the create (NewLogicBlock) and edit (ActiveLogicBlock) paths, so the auto-save effect covers both. A new block therefore auto-saves-and-switches through the same validated Add logic path — an incomplete new block blocks the switch with validation errors, exactly like pressing Add logic.

Alternatives considered

• Card body element. We kept the clickable card body as a plain Box with an onClick, and left the pencil icon button as the keyboard/screen-reader trigger, rather than turning the whole body into a focusable <button>. Making the entire card a button is more keyboard-complete, but the pencil already covers keyboard access and the Box keeps the markup simpler; we can revisit if we want full card-body keyboard focus later.
• Redundant-save short-circuit. For an already-saved card that you open but don't change, we skip the save and just switch, to avoid a pointless network write. This short-circuit deliberately does not apply to brand-new blocks — those always run validation so an empty new block can't silently vanish on switch.

Screenshots

State	Before	After
Logic card, flag on (collapsed)
Logic card, flag on (hover affordance)

Breaking Changes

No - backwards compatible. Feature is gated behind editable-cards-mrf-logic (default off); flag-off behaviour is unchanged.

Tests

TC1: Flag off — no regression

• With the flag off, open a logic card; other cards stay locked until you Save/Cancel.
• Only the pencil icon opens a card for editing.

TC2: Flag on — whole card clickable + hover

• Hovering a card highlights the whole card (border/background) and tints the pencil.
• Clicking anywhere on a card opens it for editing.

TC3: Flag on — auto-save-and-switch between existing cards

• Open card A, change something, click card B → A saves and B opens.
• If A has invalid/incomplete data, the switch is blocked and validation errors show on A.

TC4: Flag on — untouched card switches without a redundant save

• Open card A, change nothing, click card B → B opens and no save request fires for A.

TC5: Flag on — new block blocks the switch when incomplete

• Click Add logic, leave it incomplete, click an existing card → switch is blocked and validation errors show on the new block (same as pressing Add logic).

TC6: Flag on — valid new block creates then switches

• Click Add logic, fill it in validly, click an existing card → the new block is created and the clicked card opens.

[linear-code]

FRM-2491

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request