review feedback

Signed-off-by: Mark Herwege <[email protected]>
openhab · Jan 11, 2025 · 2ef6e17 · 2ef6e17
1 parent d44a3f0
commit 2ef6e17
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/bundles/org.openhab.binding.network/README.md b/bundles/org.openhab.binding.network/README.md
@@ -57,7 +57,7 @@ Use the following options for a **network:pingdevice**:
 - **useArpPing:** When set to true if the presence detection is allowed to use arp ping.
   This can speed up presence detection, but may lead to inaccurate ping latency measurements.
   Switch off if you want to use this for ping latency monitoring. Default: `true`.
-- **usePing:** When set to true if the presence detection is allowed to use ping.
+- **useIcmpPing:** When set to true if the presence detection is allowed to use icmp ping.
   When also using arp ping, the latency measurements will not be comparable.
   Switch off if you rather want to use arp ping latency monitoring. Default: `true`.
 - **networkInterfaceNames:** The network interface names used for communicating with the device.

diff --git a/bundles/org.openhab.binding.network/src/main/resources/OH-INF/i18n/network.properties b/bundles/org.openhab.binding.network/src/main/resources/OH-INF/i18n/network.properties
@@ -92,8 +92,3 @@ channel-type.network.rateDown.label = Download Rate
 channel-type.network.rateDown.description = Current download rate
 channel-type.network.rateUp.label = Upload Rate
 channel-type.network.rateUp.description = Current upload rate
-
-# thing types config
-
-thing-type.config.network.pingdevice.usePing.label = Use ICMP Ping
-thing-type.config.network.pingdevice.usePing.description = Set to true if the presence detection is allowed to use icmp ping. If you are monitoring network latency using arping, you should switch this off to prevent mixing results with arp ping results.