[mideaac] Initial contribution- second try #17749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apella12
changed the title
jlaur
added
the
new binding
wborn
reviewed
Dec 15, 2024
apella12
force-pushed
the
separate-connection-manager
branch
2 times, most recently
from
8fae5fa to
44bb90f
Compare
Mideaac binding after partial PR review. Main remaining issue is the connection manager which currently needs to be embedded in the MideaACHandler to leverage the OH base thing handler. Signed-off-by: Bob Eckhoff <[email protected]>
Working (sort of) version of split connection manager. Problem with the connection manager being null when the binding is stop/start. Need reset to clear with clean-cache too. Signed-off-by: Bob Eckhoff <[email protected]>
After initial changes, tested various scenarios and made changes so they are working like before. Signed-off-by: Bob Eckhoff <[email protected]>
forgot to run spotless on the last update Signed-off-by: Bob Eckhoff <[email protected]>
Java doc and possible mdns discovery. Signed-off-by: Bob Eckhoff <[email protected]>
spotless Signed-off-by: Bob Eckhoff <[email protected]>
Makes retries more robust. Three times for connection and one retry on the command. Signed-off-by: Bob Eckhoff <[email protected]>
Changed V2 response to align with V3 process after extra decoding. Signed-off-by: Bob Eckhoff <[email protected]>
Changed version and changed dates (in advance-hopefully ok) Signed-off-by: Bob Eckhoff <[email protected]>
Changing dates early was a bad idea Signed-off-by: Bob Eckhoff <[email protected]>
This reverts commit 44bb90f. Signed-off-by: Bob Eckhoff <[email protected]>
apella12
force-pushed
the
separate-connection-manager
branch
from
4ef6b08 to
071c1e7
Compare
|
This is not forgotten, the time I have to spare is consumed by the ZUI binding at the moment. So don’t wait for me. |
|
@lsiepel Well I'm not really waiting. I'm working on other things too. There shouldn't be much to review after you rewrote the connection manager. I did a few things to make it more robust to run without the A/C connected to the cloud and fixed some things that you left hanging. I have had it polling for months without issues. It is not exactly A/C season, so no one is exactly clamoring for an update. Hopefully you or someone else can have a look in a couple of months as we get towards spring. EDIT: I did update the version to OH5 and change the date to 2025 in the headers |
Change to new Headers Signed-off-by: Bob Eckhoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt. The first attempt is closed #17395. Essentially all of the previous comments have been addressed. The main new change is the separation of the connection manager and the MideaACHandler, (largely rewritten by @lsiepel) these two files are basically new. I have worked and tested with this version (made some modifications) for several weeks and it seems to work as well as the first attempt now. Also there were a number of new supporting files added by @lsiepel.
For reference the previous intro is here.
I’d like to put this out for new binding review.
This binding was started by the original author as a forum topic but has since had other contributors. I picked it up when I installed a mini-split AC that used the Midea protocol earlier this year, originally to allow for longer polling frequencies. Then as a retirement challenge (no formal java training), decided to attempt to clean it up for official status. I cleaned up the summary report from over 150 items and believe I conformed to current developer guidelines (Java docs, naming, tests, etc.). Along the way added some additional functionality and corrected some code issues.
The discovery and security classes remain largely unchanged from the original author (who I haven’t been able to contact), and work well. The other classes I understand pretty well at this point and hopefully can address any concerns.
As a note, to conform to the guidelines there are breaking changes in naming from the version I published on the forum thread.