-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upnpcontrol] Send periodic keep alive #17976
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dan Cunningham <[email protected]>
Signed-off-by: Dan Cunningham <[email protected]>
...trol/src/main/java/org/openhab/binding/upnpcontrol/internal/handler/UpnpRendererHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the single comment, LGTM.
Will wait for @mherwege to look at it before merging. Do you recommend to backport?
…hab/binding/upnpcontrol/internal/handler/UpnpRendererHandler.java Co-authored-by: lsiepel <[email protected]> Signed-off-by: Dan Cunningham <[email protected]>
Thanks, i would suggest backporting this one. |
I am a bit in doubt about this solution. The binding so far refrained from explicit M-SEARCH calls and relied on the upnp service for this. And you state this issue also appears with Sonos. Would it then not be better to solve this in the transport, like here: https://github.com/openhab/openhab-core/blob/1f9ba2b0eea9daf70515cd36b53c3fe1d2f1e54d/bundles/org.openhab.core.io.transport.upnp/src/main/java/org/openhab/core/io/transport/upnp/internal/UpnpIOServiceImpl.java#L434. Maybe @wborn has an opinion on this. |
This sends a periodic search packet to the remote upnp device as part of the thing's refresh cycle. This search request acts as a keep alive mechanism for devices that loose registration.
Fixes #16638