[insteon] Fix led command stack overflow error #17977
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: jsetton <[email protected]>
jsetton
force-pushed
the
insteon-led-cmd-fix
branch
from
c312eff to
ee85f2c
Compare
jlaur
pushed a commit
that referenced
this pull request
Dec 26, 2024
Signed-off-by: jsetton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending a command to a relevant feature, it sent it back to itself causing the stack overflow. Additionally, the command should be sent regardless of the current state since it may not be up to date at the time the command is received.
This bugfix should be included in 4.3.1.