[sbus] Initial contribution #18019

cipianpascu · 2025-01-02T07:46:16Z

No description provided.

…7687) Signed-off-by: Neil Greatorex <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…b#17333) At least the Deebot 900 sends an unusual error response in case of expired token. Fixes openhab#15961 Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…x on on upgrade (openhab#17703) * [jsscripting] Upgrade to openhab-js 5.8.0 Signed-off-by: Florian Hotze <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* [ism8] Add channel types for heat pumps Signed-off-by: Holger Friedrich <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Holger Friedrich <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…hab#17661) * Events were dispatched but group id was missing Signed-off-by: Gaël L'hopital <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…t temperature (openhab#17662) * setpointDefaultDuration was not always considered Signed-off-by: Gaël L'hopital <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…t filter (openhab#16105) * Extract time-based event search strategies into a separate class This allows extensions without having to adapt the logic in BiweeklyPresentableCalendar. Signed-off-by: Christian Heinemann <[email protected]> Co-authored-by: Leo Siepel <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* Provide LED channel for access Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Nick Waterton <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* Network Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Ciprian Pascu <[email protected]>

* Yet another website underlaying API modification * Correction for current and previous week, month, year * Added unitHing * Switch peek power to kVA * Adding new cookie and user agent Signed-off-by: Gaël L'hopital <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Artur-Fedjukevits <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* First version Signed-off-by: Jan Gustafsson <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* stabilize nanoleaf binding:suppress ipv6 addresses in controller discovery Signed-off-by: Stefan Höhn <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Konstantin Polihronov <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…ico (openhab#17723) * Added discovery of DivaSmartDimmer and PaddleSwitchPico. Also, it will not print out ID of any unrecongnized device in the logs. Signed-off-by: Jeff James <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* Show encrypted frames without a matching key using console command "openhab:knx list-unknown-ga"; sort output numerically by GA. * Add trace logging to show decryption error due to missing key. Previously, those frames were silently dropped unless logging for Calimero was explicitly enabled as well. Signed-off-by: Holger Friedrich <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* [shelly] Add support for Shelly Plus RGBW PM Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* [avmfritz] Fix incorrect state of dimmable bulb Fixes openhab#17609 Signed-off-by: Fabian Girgert <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…ttp (openhab#17570) Bumps org.eclipse.jetty:jetty-server from 9.4.54.v20240208 to 9.4.55.v20240627. --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-server dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ciprian Pascu <[email protected]>

Related to openhab#17636 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Ciprian Pascu <[email protected]>

I made various changes and fixes to the ONVIF connection in the IpCamera binding. Signed-off-by: David Masshardt <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* [solarman] Added LSE-3 (LAN Stick Logger) Support (openhab#17559) Signed-off-by: Peter Kretz <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…penhab#17919) * [various] process color temperature quantity type commands Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: jsetton <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

…nhab#17680) * [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

* [jsscripting] Upgrade GraalJS to 23.0.6 Signed-off-by: Florian Hotze <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Ciprian Pascu <[email protected]>

…into feature/s-bus

…b-addons into feature/s-bus

Signed-off-by: Ciprian Pascu <[email protected]>

openhab-bot · 2025-01-02T11:29:00Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-transport-protocol-s-bus-g4/152769/1

lsiepel

Thansk for this updated PR and the contribution. Many of my comments are the same issue on defferent locations. So i think with 1 or 2 more iterations we can finish this PR.

Besides these comments, also be sure all compile warnings and SAT errors are fixed. Also don;t forget to add yourself to the CODEOWNERS file.

bundles/org.openhab.binding.sbus/DEVELOPERS.md

bundles/org.openhab.binding.sbus/README.md

...g.openhab.binding.sbus/src/main/java/org/openhab/binding/sbus/handler/SbusSwitchHandler.java

...nhab.binding.sbus/src/main/java/org/openhab/binding/sbus/handler/SbusTemperatureHandler.java

lsiepel · 2025-01-05T22:56:16Z

...nhab.binding.sbus/src/main/java/org/openhab/binding/sbus/handler/SbusTemperatureHandler.java

+
+            // Iterate over all channels and update their states with corresponding temperatures
+            for (Channel channel : getThing().getChannels()) {
+                SbusChannelConfig channelConfig = channel.getConfiguration().as(SbusChannelConfig.class);


Add a check isLinked so only channels are iterated that are actually linked to an item. Saves some cpu-cycles for existing but not used channels.

I don't know how to do it. But the call to sbus devices is done only once for all the channels. It doesn't have much of an impact.

… feature/s-bus

Signed-off-by: Ciprian Pascu <[email protected]>

…an osgi service Signed-off-by: Ciprian Pascu <[email protected]>

Signed-off-by: Ciprian Pascu <[email protected]>

cipianpascu · 2025-01-11T18:43:00Z

hey @lsiepel, please help me with the spotless build issue. I don't understand why is it passing on my local computer but fails on github. Thank you

lsiepel · 2025-01-11T22:16:36Z

hey @lsiepel, please help me with the spotless build issue. I don't understand why is it passing on my local computer but fails on github. Thank you

Your branch is 18 commits behind, I think some are spotless related (version upgrade). Please update your main and afterwards your feature branch.

… feature/s-bus

cipianpascu · 2025-01-12T16:11:40Z

hey @lsiepel, please help me with the spotless build issue. I don't understand why is it passing on my local computer but fails on github. Thank you

Your branch is 18 commits behind, I think some are spotless related (version upgrade). Please update your main and afterwards your feature branch.

After the update, I had the same problem on my local computer. Apparently, there is an issue with the Eclipse JDT formatter version and Lombok dependencies, project wide.

Signed-off-by: Ciprian Pascu <[email protected]>

lsiepel · 2025-01-12T17:18:26Z

hey @lsiepel, please help me with the spotless build issue. I don't understand why is it passing on my local computer but fails on github. Thank you

Your branch is 18 commits behind, I think some are spotless related (version upgrade). Please update your main and afterwards your feature branch.

After the update, I had the same problem on my local computer. Apparently, there is an issue with the Eclipse JDT formatter version and Lombok dependencies, project wide.

It’s not spotless it is SAT. Please check the errors to fix them

Signed-off-by: Ciprian Pascu <[email protected]>

cipianpascu requested review from GiviMAD and a team as code owners January 2, 2025 07:46

ngreatorex and others added 28 commits January 2, 2025 09:49

[network] Modify iOS port knock to use a valid mDNS packet (openhab#1…

67c6fe3

…7687) Signed-off-by: Neil Greatorex <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Refactor removal of accents for Thing ID normalization (openhab#17698)

17ef86b

Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[ecovacs] Fix expired token handling for XML-over-MQTT models (openha…

03f3379

…b#17333) At least the Deebot 900 sends an unusual error response in case of expired token. Fixes openhab#15961 Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[jsscripting] Upgrade openhab-js to 5.8.0 & Add note to check core fi…

9f7c7c2

…x on on upgrade (openhab#17703) * [jsscripting] Upgrade to openhab-js 5.8.0 Signed-off-by: Florian Hotze <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[ism8] Add channel types for heat pumps (openhab#17688)

2fa28a9

* [ism8] Add channel types for heat pumps Signed-off-by: Holger Friedrich <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[ism8] Improve debug logging (openhab#17705)

64940c7

Signed-off-by: Holger Friedrich <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[netatmo] Webhook events are dispatched but group id is missing (open…

bf25a38

…hab#17661) * Events were dispatched but group id was missing Signed-off-by: Gaël L'hopital <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[netatmo] Consider setpoint duration when manual changing the setpoin…

3ae0e63

…t temperature (openhab#17662) * setpointDefaultDuration was not always considered Signed-off-by: Gaël L'hopital <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[unifi] Provide LED channel for access point (openhab#17702)

5f0e3c4

* Provide LED channel for access Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[samsungtv] Fix for incorrect PowerState (openhab#17715)

aa58d58

Signed-off-by: Nick Waterton <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[snmp] make use of openHAB network configuration (openhab#17699)

37d25ee

* Network Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

New translations icalendar.properties (Italian) (openhab#17717)

9247338

Signed-off-by: Ciprian Pascu <[email protected]>

[ChatGPT] Enhance binding (openhab#17320)

16353e9

Signed-off-by: Artur-Fedjukevits <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[electroluxappliance] Initial contribution (openhab#17663)

d28eaf8

* First version Signed-off-by: Jan Gustafsson <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[nanoleaf] Suppress ipv6 addr in controller discovery (openhab#17724)

82655e6

* stabilize nanoleaf binding:suppress ipv6 addresses in controller discovery Signed-off-by: Stefan Höhn <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Fix the parsing of total consumption channel (openhab#17726)

08e6880

Signed-off-by: Konstantin Polihronov <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[shelly] Add support for Shelly Plus RGBW PM (openhab#17692)

268eabd

* [shelly] Add support for Shelly Plus RGBW PM Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

Define grid tariff filters in YAML (openhab#17690)

d8beff5

Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[avmfritz] Fix incorrect state of dimmable bulb (openhab#17685)

de3fb1b

* [avmfritz] Fix incorrect state of dimmable bulb Fixes openhab#17609 Signed-off-by: Fabian Girgert <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[energidataservice] Fix @ActionOutput annotations (openhab#17679)

d2cbbee

Related to openhab#17636 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

New translations energidataservice.properties (Danish) (openhab#17734)

f51793d

Signed-off-by: Ciprian Pascu <[email protected]>

Various Onvif fixes for IpCamera (openhab#17732)

aa13775

I made various changes and fixes to the ONVIF connection in the IpCamera binding. Signed-off-by: David Masshardt <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[solarman] Add support for LSE-3 (LAN Stick Logger) (openhab#17563)

92daa5d

* [solarman] Added LSE-3 (LAN Stick Logger) Support (openhab#17559) Signed-off-by: Peter Kretz <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

andrewfg and others added 11 commits January 2, 2025 09:49

[amazonechocontrol] Support QuantityType Color Temperature command (o…

1c26aea

…penhab#17919) * [various] process color temperature quantity type commands Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[insteon] Refactor iostream transport classes (openhab#17930)

1bd25ff

Signed-off-by: jsetton <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[miio] Add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 (ope…

18f78d2

…nhab#17680) * [miio] add support for Smart Air Purifier 4 Lite zhimi.airp.rmb1 Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[jsscripting] Upgrade GraalJS from 22.0.0.2 to 24.1.1 (openhab#17720)

b4b8015

* [jsscripting] Upgrade GraalJS to 23.0.6 Signed-off-by: Florian Hotze <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] first rewritten version

f699c85

Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] testing and fixes

a7719c5

Signed-off-by: Ciprian Pascu <[email protected]>

final implementation for switch, temperature & rgbw things

2b353ef

Signed-off-by: Ciprian Pascu <[email protected]>

Merge branch 'main' of https://github.com/cipianpascu/openhab-addons …

0b3e844

…into feature/s-bus

Merge branch 'feature/s-bus' of https://github.com/cipianpascu/openha…

b5e5508

…b-addons into feature/s-bus

[sbus] fix feature dependencies

04960a8

Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] fix copyright / year

4664ba7

Signed-off-by: Ciprian Pascu <[email protected]>

jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 2, 2025

jlaur changed the title ~~Feature/s bus~~ [sbus] Initial contribution Jan 2, 2025

cipianpascu mentioned this pull request Jan 2, 2025

S-Bus transport protocol. Derived from Modbus protocol openhab/openhab-core#4025

Closed

lsiepel requested changes Jan 5, 2025

View reviewed changes

Ciprian Pascu added 5 commits January 7, 2025 15:06

Merge branch 'main' of https://github.com/openhab/openhab-addons into…

a129162

… feature/s-bus

[sbus] fix required changes to become compliant

04f0cea

Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] keep the j2sbus package internal by decoupling all calls with …

95781b1

…an osgi service Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] fix sat issues

31c409f

Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] fix sat issues

d1fa64f

Signed-off-by: Ciprian Pascu <[email protected]>

Merge branch 'main' of https://github.com/openhab/openhab-addons into…

fe10c83

… feature/s-bus

[sbus] apply suggested changes

b2935be

Signed-off-by: Ciprian Pascu <[email protected]>

GiviMAD removed their request for review January 12, 2025 16:46

Ciprian Pascu added 2 commits January 12, 2025 19:34

[sbus] fix sat issues

20fc495

Signed-off-by: Ciprian Pascu <[email protected]>

[sbus] some comments and optimized calls

de08032

Signed-off-by: Ciprian Pascu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sbus] Initial contribution #18019

[sbus] Initial contribution #18019

cipianpascu commented Jan 2, 2025

openhab-bot commented Jan 2, 2025

lsiepel left a comment

lsiepel Jan 5, 2025

cipianpascu Jan 12, 2025

cipianpascu commented Jan 11, 2025

lsiepel commented Jan 11, 2025

cipianpascu commented Jan 12, 2025

lsiepel commented Jan 12, 2025

[sbus] Initial contribution #18019

Are you sure you want to change the base?

[sbus] Initial contribution #18019

Conversation

cipianpascu commented Jan 2, 2025

openhab-bot commented Jan 2, 2025

lsiepel left a comment

Choose a reason for hiding this comment

lsiepel Jan 5, 2025

Choose a reason for hiding this comment

cipianpascu Jan 12, 2025

Choose a reason for hiding this comment

cipianpascu commented Jan 11, 2025

lsiepel commented Jan 11, 2025

cipianpascu commented Jan 12, 2025

lsiepel commented Jan 12, 2025