[linktap] Bugfix Issue 18076 #18090
Open
[linktap] Bugfix Issue 18076 #18090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[linktap] Bugfix Issue 18076 Signed-off-by: David Goodyear <[email protected]>
|
4.3.X branch PR is here: #18077 |
|
@jlaur This is the patch to main, if the patches are cherry picked for the 4.3.X branch, we just need this PR don't we, then it can be cherry picked back to the 4.3.X branch? Sorry first time, I've had to do something that should go backwards as a bug. If so I can close the other PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[linktap] Bugfix Issue 18076
This is the patch for the main branch for the LinkTap corrections.
Timing changes in the firmware have highlighted some potential race conditions that can occur, with older firmware's it may also happen.
Consequently, these changes ensure that the race conditions cannot happen, meaning the communications stack misses device registration to the gateway's data. New defensive checks on CMD16 ensure that incorrect responses are ignored / handled, which can occur when the gateway is booting up. The new ret code's are being rolled out in a firmware now globally, so these changes ensure that reply has a ret status that shows CMD16 is not ready to be used, the binding falls back, and will try again when the gateway is ready.
In addition it was noted during testing that NoRouteToHost exceptions were not being picked up correctly (when switching WiFi networks during tests), which meant that the auto reconnect capability was not running. This also add's handling by catch the SocketException base class of NoRouteToHostException, to ensure its is handled correctly.
This need's to be cherry picked back to the 4.3.X branch. In case this has to be merged first I'm adding this and linking both the PR's together. (Currently there is a PR against the 4.3.X branch with the same changes in - adding link to the comments).