[basicprofiles] Fix inability to filter a percent QuantityType input #18091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/state-filter-range-filter-profile/158025/43 |
jimtng
force-pushed
the
statefilter-input
branch
from
e31c9f6 to
d116107
Compare
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
statefilter-input
branch
from
d116107 to
402f179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally to filter the values of QuantityType inputs, the conditions are written as
> min_value, e.g.> 100 W. However, when the QuantityType is a percent, writing it as> 10 %caused the statefilter parser to think it's a $DELTA_PERCENT check instead of checking the actual input value.This is a bug and a problem, preventing the state filter from being used to filter a percent quantity type.
This PR fixes this problem by adding a new $INPUT function which can be used in this situation to help the parser, so the condition needs to be rewritten as
$INPUT > 10 %to achieve "input-value-filter" instead of "delta-percent-filter".This should be backported to 4.3