Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(18062): ๐Ÿ› ๏ธ [huesync] Configuration (API Token) lost if device goes offline #18100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pgfeller
Copy link
Contributor

@pgfeller pgfeller commented Jan 12, 2025

Refactoring of connection handling

  • Analyze and reproduce issue; poc - ๐Ÿ› ๏ธ work in progress ๐Ÿ› ๏ธ
  • rebase branch (force push)
  • Avoid exceptions in constructor (handler)
  • Do not delete configuration automatically
  • Re-initialize connection (e.g. if IP/Hostname changed)
  • prepare for review (rebase, squash)

@pgfeller pgfeller added the work in progress A PR that is not yet ready to be merged label Jan 12, 2025
@pgfeller pgfeller self-assigned this Jan 12, 2025
... will be rebased and squashed once completed.

Signed-off-by: Patrik Gfeller <[email protected]>
@pgfeller pgfeller force-pushed the huesync/issue/18062 branch from f1dfb75 to 48daebe Compare January 12, 2025 21:55
@pgfeller pgfeller requested a review from lsiepel January 12, 2025 21:58
@pgfeller
Copy link
Contributor Author

Hi @lsiepel - I've added you as reviewer already, but the fix is far from ready to be merged. But maybe it is easier for you to follow how the fix evolves rather than to review all at once. That way you can also comment at any time if you have concerns.

hope you are fine and as always - thanks for your work for the community and especially for your support to me ๐Ÿ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress A PR that is not yet ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant