-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule Template installation fixes #4591
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
Trying to check if deleted files are hidden, are readable or are directories will result in IOExceptions on many file systems, so that no action will be taken for deletions. Signed-off-by: Arne Seime <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/marketplace-versioning-with-embedded-resource/161421/202 |
7ff9145
to
d07f695
Compare
Ready for review/discussion. This is a collaboration between @seime and me, so I'll add a bit of information. There has been support for file-based rule templates ( The reason it was broken is that the path used in the "file watcher" was wrong, so it responded by looking for the changed file in a different location and thus always failed to pick up anything. While we fixed this, we also found that there was another problem with the "file watcher" handling: The use of calls that potentially cause file system access as a way to filter out files, which fails for To explain, it was for example checked if the file has hidden, and hidden files were filtered out. On Linux file systems, that work just fine, because you can deduct whether it's hidden from the file name itself (does it start with a The last commit in this PR is therefore strictly unrelated to rule templates, it just fixes the same issue in other places in core where the same problem was discovered. Once the file-based rule templates were up and working, it turned out that only JSON was supported. Rule templates are often scripts like JavaScript. It's very inconvenient to write a whole script on one line separated by |
Solves #4589 . |
Rule Template installation fixes