Alpine image: Install NodeJS for Matter binding #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <[email protected]>
wborn
requested changes
Jan 7, 2025
alpine/Dockerfile
Outdated
| @@ -57,6 +57,7 @@ RUN apk update --no-cache && \ | |||
| tini \ | |||
| ttf-dejavu \ | |||
| openjdk${JAVA_VERSION} \ | |||
| nodejs \ | |||
There was a problem hiding this comment.
It only makes sense to install it for OH 5 or newer and not OH 4 (or older) which use the same files.
You can prevent that by adding some conditional logic based on the version.
See the Debian Dockerfile for how this is done (ref1, ref2).
Is there already a PR for the Matter add-on? Merging this PR depends on if that gets merged.
There was a problem hiding this comment.
No, there is no Matter PR yet, but I am sure it will get merged given the interest of openHAB maintainers on it.
Not having NodeJS in thr Alpine image available will prevent users from installing and testing the Matter binding from thr marketplace through.
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
force-pushed
the
alpine-nodejs
branch
from
e79d4d8 to
61b961d
Compare
Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openhab/openhab-distro#1693 (comment).