Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Input files for Crashlytics #827

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Add Input files for Crashlytics #827

merged 3 commits into from
Sep 18, 2024

Conversation

timbms
Copy link
Contributor

@timbms timbms commented Sep 17, 2024

Crashlytics requires input files to be set as described here to upload symbols. These were not set.

Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timbms
Copy link
Contributor Author

timbms commented Sep 18, 2024

I just wonder whether we rather should upload with fastlane when submitting

@digitaldan digitaldan merged commit 0d86170 into develop Sep 18, 2024
1 of 2 checks passed
@digitaldan digitaldan deleted the crashlyticsInputFiles branch September 18, 2024 16:11
@digitaldan
Copy link
Contributor

Sorry i missed your comment before merging, i don't have any opinion since this is new for me. Let me know if you want to proceed with this, or revert it back.

@timbms
Copy link
Contributor Author

timbms commented Sep 18, 2024

Fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants