Skip to content

Commit

Permalink
Remove "Other Services" section from main settings page (#1891)
Browse files Browse the repository at this point in the history
Add-on service settings are configurable from the respective add-on's
page and therefore the "Other Services" section of the main settings
page is not needed anymore.
Services provided by openHAB core that were previously listed unter
"Other Services" were moved to "System Services".

Signed-off-by: Jan N. Klug <[email protected]>
  • Loading branch information
J-N-K authored Jun 4, 2023
1 parent a478359 commit a8ef9cc
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions bundles/org.openhab.ui/web/src/pages/settings/settings-menu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,6 @@
:link="'services/' + service.id"
:title="service.label" />
</f7-list>
<f7-block-title>Other Services</f7-block-title>
<f7-list class="search-list">
<f7-list-item
v-for="service in otherServices"

This comment has been minimized.

Copy link
@splatch

splatch Jun 19, 2023

Contributor

@J-N-K I think this section could be populated with configurable services, other than these related to addons and system services.

:key="service.id"
:link="'services/' + service.id"
:title="service.label" />
</f7-list>
</f7-col>
</f7-row>
<f7-block-footer v-if="$t('home.overview.title') !== 'Overview'" class="margin text-align-center">
Expand All @@ -161,7 +153,6 @@ export default {
servicesLoaded: false,
addonStoreTabShortcuts: AddonStoreTabShortcuts,
systemServices: [],
otherServices: [],
objectsSubtitles: {
things: 'Manage the physical layer',
model: 'The semantic model of your home',
Expand Down Expand Up @@ -201,7 +192,6 @@ export default {
// can be done in parallel!
servicesPromise.then((data) => {
this.systemServices = data.filter(s => s.category === 'system')
this.otherServices = data.filter(s => s.category !== 'system')
this.servicesLoaded = true
})
},
Expand Down

0 comments on commit a8ef9cc

Please sign in to comment.