-
-
Notifications
You must be signed in to change notification settings - Fork 268
Moved to blockly v11 and respective plugin versions #3398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
#3518 Bundle Size — 12.52MiB (+1.78%).7121969(current) vs 20795a4 main#3511(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Warning Bundle introduced 4 new packages: @mit-app-inventor/blockly-plugin-workspace-multiselect, dragselect, @blockly/field-colour and one more – View changed packages Bundle metrics
Bundle size by type
Bundle analysis report Branch jsjames:blockly-v11 Project dashboard Generated by RelativeCI Documentation Report issue |
'@mit-app-inventor/blockly-plugin-workspace-multiselect' working. Required updating of imports and making sure 'workspace' was not reactive (https://groups.google.com/g/blockly/c/myo3FXL3r_Y/m/NLgPZNc0CgAJVue3). added support for blockly comments (add comment via context menu) Signed-off-by: Jeff James <[email protected]>
|
As testing Blockly is always a larger effort for @stefan-hoehn, I wonder whether we shouldn't try to upgrade to Blockly 12 now, so we don't need to test twice. WDYT @jsjames? |
I did try, but the plugin @mit-app-inventor/blockly-plugin-workspace-multiselect does not yet support it . Since there is an issue with our vue3 version where multi-select does not currently work (I recall it being a runtime issue in the @mit-app-inventor/blockly-plugin-workspace-multiselect ), this was the most expedient way to address. The question is how critical is it to get the multi-select feature working? |
|
That’s quite unfortunate. |
v11 does get rid of the remaining deprecated packages warnings in package.json! |
Moved to v11 to address issues with '@mit-app-inventor/blockly-plugin-workspace-multiselect' in port to vue3.