Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkill java after restart to eventually break out of startup loop #1897

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

mstormi
Copy link
Contributor

@mstormi mstormi commented Aug 11, 2024

Fixes: #1870

not 100% sure it's ok to remove the restart command, but the effect should be the same (except for the speedup, of course)

@mstormi mstormi requested a review from ecdye August 11, 2024 20:13
Copy link
Contributor

@ecdye ecdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add back the restart after because it appears that the checks are failing because openHAB never actually restarts otherwise. See if adding it back helps and then we could go from there.

@mstormi
Copy link
Contributor Author

mstormi commented Aug 14, 2024

will do but wonder if I can instead add "-now" to systemctl enable cmd some lines up

Copy link
Contributor

@ecdye ecdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you wanted to try adding the enable -now, I think it's worth a shot, but I wonder if that wouldn't cover all cases because of upgrades.

@mstormi
Copy link
Contributor Author

mstormi commented Aug 16, 2024

Well EITHER -now and no additional restart OR no -now and restart but not both.
Switch or leave it like it is now with the merged PR?

@mstormi mstormi merged commit 3e654ce into main Aug 16, 2024
13 checks passed
@mstormi mstormi deleted the javakill branch August 16, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup loop
2 participants