-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove frontail by default #1933
Conversation
See openhab#1921 for more specific details for the reasoning. Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
I agree with @mherwege uninstall should be completely optional for now. Please add a big warning instead to pop up during frontail install that it is still useable but no longer supported. We can revisit when either the builtin viewer improved or someone contributes a frontail alternative see #1921 . Please add back the openhabian.conf options for unattended install, too. |
The newly built in viewer, at least for now, isn't an alternative for everybody yet. @ecdye That removal was too hasty. Please next time don't merge such changes without prior consent. Plus, for any changes, put them up for main branch but do not forward them straight away to openHAB branch. I've commented remove_frontail() out for now in openHAB branch as a quick stop. |
Yes, I was a little rushed in merging that change. My apologies, I was up late last night finishing up the final touches on the In general I think we could both do better about waiting until reviews have been given to merge things and not directly merging into main using Maintainer access. I'll look into adding some additional checks to help us both be more compliant in the future with the reviews required policy outlined in the openHAB docs.
Yes, once again my apologies, I had to forward the
I will work on that sometime in the next day or two. I plan to make it very clear that it is not a supported model anymore as I'm really done with frontail and all of the headaches it has given me over the years. |
I understand you, this can happen at times and yes, I've been pretty much hating frontail ever since I had to resolve my first issue with it some years ago, too. People talked to me as if I had been the person to have selected it (it wasn't me!!) and went on to urge me fix it anytime something didn't work. But users have no proper alternative yet so we must at least keep it available to them for some more time. |
I wish I had never taken the time to give it an update to make it limp along 2 years ago, because now it has just made it more of a headache but here we are.
Yeah, but I will be really annoying and if they are on openHAB 4.3+ I will make a pop up appear every time the use |
This reverts commit cc5489164816cac0c708029ca4b7fafb2cc4920f. Signed-off-by: Ethan Dye <[email protected]>
Related #1933 Signed-off-by: Ethan Dye <[email protected]>
* Revert "Remove frontail by default (#1933)" This reverts commit cc5489164816cac0c708029ca4b7fafb2cc4920f. * Prompt user to remove frontail Related #1933 * Update docs for deprecation of frontail * Update wording in NEWS for clarity --------- Signed-off-by: Ethan Dye <[email protected]>
See #1921 for more specific details for the reasoning.