Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PMD to 7.8.0 #471

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Upgrade PMD to 7.8.0 #471

merged 1 commit into from
Dec 13, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 7, 2024

@wborn wborn requested a review from a team as a code owner December 7, 2024 17:33
@wborn wborn marked this pull request as draft December 7, 2024 20:49
@wborn wborn marked this pull request as ready for review December 8, 2024 12:46
@wborn
Copy link
Member Author

wborn commented Dec 8, 2024

PMD 7.8.0 still works with Java 11, see: https://docs.pmd-code.org/pmd-doc-7.8.0/pmd_devdocs_building.html

Looks like the newer Jenkins versions using JDK 17 only support Maven projects using older JDKs via toolchains:

ERROR: ================================================================================
ERROR: Invalid project setup: Failed to load hudson.maven.AbstractMavenProcessFactory$ConfigureOriginalJDK
ERROR: [JENKINS-18403][JENKINS-28294] JDK 'OpenJDK 11' not supported to run Maven projects.
ERROR: Maven projects have to be launched with a Java version greater or equal to the minimum version required by the controller.
ERROR: Use the Maven JDK Toolchains (plugin) to build your maven project with an older JDK.
ERROR: Retrying with agent Java and setting compile/test properties to point to /var/jenkins_home/tools/hudson.model.JDK/OpenJDK_11.
ERROR: ================================================================================

GitHub Actions also builds using Java 11 without any issues.

Furthermore:

https://plugins.jenkins.io/maven-plugin/#plugin-content-risks

Risks

The Jenkins project recommends that users transition from the Maven job type to use Pipeline jobs or freestyle jobs. Stephen Connolly describes many of the reasons in his 2013 blog post, "Jenkins' Maven job type considered evil".

I'd personally rather spend my time on migrating everything to GitHub Actions. 😉

@kaikreuzer kaikreuzer merged commit b38579e into openhab:main Dec 13, 2024
2 of 3 checks passed
@kaikreuzer kaikreuzer added this to the 0.16.0 milestone Dec 13, 2024
@wborn wborn deleted the pmd-7.8.0 branch December 14, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants