Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ana06/get-changed-files instead of jitterbit/get-changed-files #1640

Merged

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Dec 20, 2022

jitterbit/get-changed-files@v1 often fails with errors like:

Base commit: c06f2fe4456f933cafcde33a8a764a2d7bf47635 
Head commit: 55342d52e87b98e9d2d06d2b1c54152d7d4acc02 
Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo. All: components/perf-tools/msr-safe/SPECS/msr-safe.spec Added:
Modified: components/perf-tools/msr-safe/SPECS/msr-safe.spec Removed:
Renamed:
Added or modified: components/perf-tools/msr-safe/SPECS/msr-safe.spec

This issue is known since a long time but it seems the action is not maintained anymore:
https://github.com/jitterbit/get-changed-files/issues?q=The+head+commit+for+this+pull_request+event+is+not+ahead

https://github.com/Ana06/get-changed-files is a maintained fork that claims to have fixed this issue: jitterbit/get-changed-files#11 (comment)

Signed-off-by: Martin Tzvetanov Grigorov [email protected]

jitterbit/get-changed-files@v1 often fails with errors like:

Base commit: c06f2fe
Head commit: 55342d5
Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.
All: components/perf-tools/msr-safe/SPECS/msr-safe.spec
Added:
Modified: components/perf-tools/msr-safe/SPECS/msr-safe.spec
Removed:
Renamed:
Added or modified: components/perf-tools/msr-safe/SPECS/msr-safe.spec

This issue is known since a long time but it seems the action is not
maintained anymore:
https://github.com/jitterbit/get-changed-files/issues?q=The+head+commit+for+this+pull_request+event+is+not+ahead

https://github.com/Ana06/get-changed-files is a maintained fork that
claims to have fixed this issue: jitterbit/get-changed-files#11 (comment)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@adrianreber
Copy link
Member

Good idea. One thought I had about this is if we should use the custom script for Cirrus CI just everywhere or use the fixed GitHub Actions script like in this change.

Extend tests/ci/cirrus_get_changed_files.sh to handle GitHub Actions and probably pushes or do it like in this PR. Extending our own script sounds more work and also unnecessary. So maybe just we should just use this PR.

@martin-g
Copy link
Contributor Author

martin-g commented Dec 20, 2022

The new Github action fixed our issues at https://github.com/ohpc-openeuler/ohpc/actions

ohpc-openeuler#90

@Yikun
Copy link
Contributor

Yikun commented Dec 20, 2022

@martin-g Thanks, I'm +1 on this to get GA work, if we still facing many error, we can consider the custom script. : )

@adrianreber adrianreber merged commit 7d4c910 into openhpc:2.x Dec 20, 2022
@martin-g martin-g deleted the use-newer-git-changed-files-action branch December 20, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants