csr_regfile: Fix irq/ex delegation in RVH #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RVH, interrupts are currently delegated if hxdeleg is set but mxdeleg
is not, violating the spec ("A trap/irq *that has been delegated to
HS-mode (using mxdeleg)* is further delegated to VS-mode if the
corresponding hxdeleg bit is set"). Fix and simplify the corresponding logic.
Signed-off-by: Nils Wistoff <[email protected]>
|
✔️ successful run, report available here. |
|
Hi @niwis, nice catch! Yes it's correct :) |
|
✔️ successful run, report available here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RVH, traps and interrupts are currently delegated if
hxdelegis set butmxdelegis not (mxdelegis not considered in the else-if-block condition in old line 1807), violating the spec ("A trap/irq that has been delegated to HS-mode (usingmxdeleg) is further delegated to VS-mode if the correspondinghxdelegbit is set"). Fix and simplify the corresponding logic.@ninolomata can you confirm this?