Add references to Ecosystem Implementation Guidelines section #312
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubamrein
reviewed
Oct 16, 2025
| - Whether to use the W3C Digital Credentials API, Redirects with custom URL schemes and/or Redirects with claimed `https` scheme URIs for presentation (see (#scope)) | ||
| - Which Credential format to support across issuance and presentation (see (#scope)) | ||
| - Whether to use Signed Issuer Metadata or not (see (#issuer-metadata)) | ||
| - How to make a Credential Offer to the Wallet (see (#credential-offer)) |
There was a problem hiding this comment.
Suggested change
| - How to make a Credential Offer to the Wallet (see (#credential-offer)) | |
| - How a Credential Offer is made available to the Wallet (see (#credential-offer)) |
I'm not sure what the exact intention was in the rephrasing, but I'm not sure if How to make a Credential Offer to the Wallet captures the same meaning as to send.
c2bo
reviewed
Oct 17, 2025
| - Support or restriction of additional cryptographic suites and hash algorithms | ||
| This document intentionally leaves certain extensions for ecosystems to define, in order to enable broad compatibility across differing or even conflicting requirements. Below are the extension points listed in this specification: | ||
|
|
||
| - Whether to adopt a presentation profile, issuance profile, or both (see (#scope)) |
There was a problem hiding this comment.
Would it make sense to formulate this a bit more generic - something like this?
Suggested change
| - Whether to adopt a presentation profile, issuance profile, or both (see (#scope)) | |
| - Which profiles (e.g., presentation or issuance profiles) to adopt (see (#scope)) |
| - Which Credential format to support across issuance and presentation (see (#scope)) | ||
| - Whether to use Signed Issuer Metadata or not (see (#issuer-metadata)) | ||
| - How to make a Credential Offer to the Wallet (see (#credential-offer)) | ||
| - Which key attestation format to use (see (#key-attestation)) |
There was a problem hiding this comment.
Suggested change
| - Which key attestation format to use (see (#key-attestation)) | |
| - Which Key Attestation format to use (see (#key-attestation)) |
| - Whether to use Signed Issuer Metadata or not (see (#issuer-metadata)) | ||
| - How to make a Credential Offer to the Wallet (see (#credential-offer)) | ||
| - Which key attestation format to use (see (#key-attestation)) | ||
| - Which wallet attestation format to use (see (#wallet-attestation)) |
There was a problem hiding this comment.
Suggested change
| - Which wallet attestation format to use (see (#wallet-attestation)) | |
| - Which Wallet Attestation format to use (see (#wallet-attestation)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the WG call on October 9th, I've added references to the relevant extension points in the specification. I've also improved the wording to say that the list is exhaustive.
Would like for someone to check if the wording of the points is correct, in particular the one below