Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add key attestations #389
base: main
Are you sure you want to change the base?
add key attestations #389
Changes from 30 commits
6da765e
876c29c
feced43
56e26fc
7c0baa3
a96b09b
f5db4bf
6e3a118
64878e0
1932f71
3c15c3c
ef84be4
bfa2a26
8a8dcfd
42de92f
1b98041
23c8762
7735e1c
05aa467
246e083
33612a3
4e6dc79
1f9e94b
1131416
f71e748
4b3c00d
c148e8c
4d803c0
f9cfdba
b004300
638cc52
3c6bb15
02aaaa9
0641305
5677f13
19b7815
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this look good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually prototyping an implementation of this. If there are multiple keys, do we create multiple credentials? Can this be made clear in the spec one way or another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will improve the text in the proof types section on this. Which of these scenarios are you looking into: #389 (comment) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check https://github.com/openid/OpenID4VCI/pull/389/files#r1797063233
however, it seems currently underspecified in general in OpenID4VCI that the amount of keys in the request maps to the credentials array in the response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does a (Cloud) HSM PIN fit in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point, what do you think about "remote_pin" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this section to only talk about user authentication and not combine it with different storage type. We should differentiate between different types of authentication like
pin
,biometry
etc and where in the overarching system you authenticate: directly at the key storage or with the system.For this specific section, it should not matter if you authenticate with the system and the system does a secure call to a cloud HSM or an internal one imho. That part should become clear from the key_type.