Start testing OpenIddict on .NET 7.0 #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I opened dotnet/aspnetcore#44661 to discuss that with the ASP.NET team. |
kevinchalet
commented
Oct 20, 2022
| @@ -292,7 +292,7 @@ protected virtual async ValueTask CreateEntryAsync(object key, TApplication? app | |||
| } | |||
|
|
|||
| entry.SetSize(1L); | |||
| entry.SetValue(application); | |||
| entry.SetValue(application!); | |||
There was a problem hiding this comment.
See dotnet/runtime#77264.
kevinchalet
commented
Oct 20, 2022
src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkApplicationStore.cs
Outdated
Show resolved
Hide resolved
kevinchalet
force-pushed
the
net7.0
branch
3 times, most recently
from
62ad4a5
to
701ec64
Compare
|
Merging. The next OpenIddict 4.0 preview will integrate a .NET 7.0 TFM and 7.0 RC2 references. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds .NET 7.0 TFMs and 7.0-rc2 package references so we can start testing OpenIddict on .NET 7.0. Unfortunately, it seems broken on ASP.NET Core 7.0 due to the recent changes in the authentication stack...