fix(qwen35): guard baked head dims, not the runtime value-head count#536
Merged
xiaguan merged 1 commit intoJul 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #517.
The qwen35 config guard required
linear_num_value_heads == 32, which blocked Qwen3.5-27B's 48 value heads at startup. That guard was too strict: the GDN Triton-AOT kernels take the head counts as runtime arguments; the baked constraints are the head dims / tile sizes.This PR removes the value-head-count guard, keeps the real GDN dim guard (
128/128), and adds fail-loud checks for the other baked assumptions the crate already depends on: full-attentionhead_dim == 256and divisible linear key/value head grouping. The Triton kernel source's staleH=32comment and unusedQWEN35_GDR_HEADSconstant are removed to match.Test Env
Type of Change