-
Notifications
You must be signed in to change notification settings - Fork 75
fix(kernels): catch C++ exceptions at the FFI boundary and surface the message #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xiaguan
merged 4 commits into
openinfer-project:main
from
FeathBow:fix/kernels-ffi-exception-catch
Jul 4, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8028dfa
fix(kernels): catch C++ exceptions at the FFI boundary and surface th…
FeathBow c7133ae
fix(qwen3): reject unsupported GQA group sizes at load
FeathBow e0f3e1a
fix(qwen35): surface FFI exception messages at the direct hd256 call …
FeathBow b188365
chore(qwen3): surface FFI exception messages in the kernel bench
FeathBow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Catch C++ exceptions (FlashInfer throws from host-side dispatch) before they | ||
| // cross the extern "C" boundary — a foreign exception reaching Rust aborts the | ||
| // process with no message. | ||
| #pragma once | ||
|
|
||
| #include <exception> | ||
|
|
||
| void openinfer_ffi_set_last_error(const char* what); | ||
|
|
||
| // Entering a guard clears the previous message so a -1 seen by Rust never | ||
| // reads a stale what() from an earlier call on the same thread. | ||
| #define OPENINFER_FFI_GUARD_BEGIN \ | ||
| openinfer_ffi_set_last_error(""); \ | ||
| try { | ||
| #define OPENINFER_FFI_GUARD_END(ret_on_throw) \ | ||
| } \ | ||
| catch (const std::exception& e) { \ | ||
| openinfer_ffi_set_last_error(e.what()); \ | ||
| return ret_on_throw; \ | ||
| } \ | ||
| catch (...) { \ | ||
| openinfer_ffi_set_last_error("unknown C++ exception"); \ | ||
| return ret_on_throw; \ | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #include "ffi_guard.cuh" | ||
|
|
||
| #include <string> | ||
|
|
||
| namespace { | ||
| thread_local std::string g_ffi_last_error; | ||
| } | ||
|
|
||
| void openinfer_ffi_set_last_error(const char* what) { | ||
| g_ffi_last_error = what == nullptr ? "" : what; | ||
| } | ||
|
|
||
| extern "C" const char* openinfer_kernels_last_error() { return g_ffi_last_error.c_str(); } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.