make the upstream cluster-autoscaler chart common to all #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
requested review from
ktkfree,
intelliguy,
robertchoi80,
seungkyua,
kyuho24,
cho4036 and
Siyeop
intelliguy
reviewed
Oct 30, 2023
zugwan
force-pushed
the
common_cluster-autoscaler
branch
from
3a0d0b6
to
fd31515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openinfradev/decapod-base-yaml#276 과 같이 반영이 되어야 합니다.
Mananged Control plane과 EKS 각각 분리해서 사용하던 cluster-autoscaler 차트를 업스트림 차트(https://github.com/kubernetes/autoscaler/tree/master/charts/cluster-autoscaler)로%EB%A1%9C) 통일합니다.
이력
Managed controle plane: cluster-api 프로바이더 지원을 위한 내역이 부족하여 업스트림과 별도로 차트를 만들어서 사용 (https://github.com/openinfradev/helm-charts/tree/main/cluster-autoscaler)
EKS: AWS 프로바이더를 사용하여 적용
최신 버전에서는 cluster-api 프로바이더를 위해 필요한 부분도 모두 포함되어 있어 업스트림 차트를 공통적으로 사용하도록 수정
차이점