Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release to develop ( 231031) #199

Merged
merged 5 commits into from
Oct 31, 2023
Merged

release to develop ( 231031) #199

merged 5 commits into from
Oct 31, 2023

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Oct 31, 2023

release to develop ( 231031)

@gitguardian
Copy link

gitguardian bot commented Oct 31, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
1296558 Slack Webhook URL c17a0e5 byoh-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret c17a0e5 byoh-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret ad9824a byoh-ssu-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret 5590c47 byoh-stage-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret 5590c47 byoh-suy-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret ad9824a byoh-stage-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret 5590c47 byoh-ssu-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret ad9824a byoh-suy-reference/lma/site-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ktkfree ktkfree merged commit fef48e1 into develop Oct 31, 2023
1 of 2 checks passed
@ktkfree ktkfree deleted the release branch October 31, 2023 04:45
@ktkfree ktkfree restored the release branch October 31, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants