-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put restored Java process on foreground instead of restorewait #133
Conversation
👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into |
@rvansa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@rvansa this pull request can not be integrated into git checkout restorewait_fix_fg
git fetch https://git.openjdk.org/crac.git crac
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge crac"
git push |
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@AntonKozlov please review this and CRaC/criu#14 |
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Solves a scenario where we restore the process in background,
fg
it and then try to Ctrl+C interrupt it.The usefulness of this actually depends on CRaC/criu#14
criuengine
restorewait does not have tty on stdin/stdout/stderr, though one FD is open to tty; we have to find it.Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/133/head:pull/133
$ git checkout pull/133
Update a local copy of the PR:
$ git checkout pull/133
$ git pull https://git.openjdk.org/crac.git pull/133/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 133
View PR using the GUI difftool:
$ git pr show -t 133
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/133.diff
Webrev
Link to Webrev Comment