-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346610: Make all imports conformant in the FFM API #22827
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
import java.util.Objects; | ||
import java.util.Optional; | ||
import java.util.List; | ||
|
||
import jdk.internal.foreign.FunctionDescriptorImpl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious where this style/convention is coming from, I've always put internal packages after the import of standard APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both alternatives were present and I picked the most prevailing one in the package. Also, this is what you get when you auto format in IntelliJ. But if there is a preference for the other way, we could switch. No problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any strong opinion on the topic, I was mostly just curious when I saw "conformant" in the title.
This PR proposes to clean up all the imports in the FFM lib (excluding tests).
Passes tier1-tier3
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22827/head:pull/22827
$ git checkout pull/22827
Update a local copy of the PR:
$ git checkout pull/22827
$ git pull https://git.openjdk.org/jdk.git pull/22827/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22827
View PR using the GUI difftool:
$ git pr show -t 22827
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22827.diff
Using Webrev
Link to Webrev Comment