-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336412: sun.net.www.MimeTable has a few unused methods #22831
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back vy! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
|
Webrevs
|
Hello Volkan, the changes look good to me. I agree with Roger that marking this (internal) class a |
Implemented requested changes and submitted the new successful |
String getTempFileTemplate() { | ||
return tempFileTemplate; | ||
} | ||
|
||
public synchronized Enumeration<MimeEntry> elements() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop elements
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sun.net.www.MimeTable#find
seems unused too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 82f2b3a, removed all unused methods and decreased the visibility (i.e., added private
, and, if possible, final
) wherever possible. (Successful tier1
run report is attached to the ticket.)
Cleans up
sun.net.www.MimeTable
:Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22831/head:pull/22831
$ git checkout pull/22831
Update a local copy of the PR:
$ git checkout pull/22831
$ git pull https://git.openjdk.org/jdk.git pull/22831/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22831
View PR using the GUI difftool:
$ git pr show -t 22831
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22831.diff
Using Webrev
Link to Webrev Comment