Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336412: sun.net.www.MimeTable has a few unused methods #22831

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vy
Copy link
Contributor

@vy vy commented Dec 19, 2024

Cleans up sun.net.www.MimeTable:

  • Removes unused methods & variables
  • Removes commented out code
  • Simplifies iterations over arrays

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8336412: sun.net.www.MimeTable has a few unused methods (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22831/head:pull/22831
$ git checkout pull/22831

Update a local copy of the PR:
$ git checkout pull/22831
$ git pull https://git.openjdk.org/jdk.git pull/22831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22831

View PR using the GUI difftool:
$ git pr show -t 22831

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22831.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2024

👋 Welcome back vy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2024
@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@vy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@vy
Copy link
Contributor Author

vy commented Dec 19, 2024

tier1 tests pass on 91554c5 – the run report is shared in the ticket.

@mlbridge
Copy link

mlbridge bot commented Dec 19, 2024

Webrevs

@jaikiran
Copy link
Member

Hello Volkan, the changes look good to me. I agree with Roger that marking this (internal) class a final would be a good idea.

@vy
Copy link
Contributor Author

vy commented Dec 23, 2024

Implemented requested changes and submitted the new successful tier1 test report. I'd appreciate one final review, so that I can /integrate.

String getTempFileTemplate() {
return tempFileTemplate;
}

public synchronized Enumeration<MimeEntry> elements() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop elements as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sun.net.www.MimeTable#find seems unused too

Copy link
Contributor Author

@vy vy Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 82f2b3a, removed all unused methods and decreased the visibility (i.e., added private, and, if possible, final) wherever possible. (Successful tier1 run report is attached to the ticket.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants