Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346667: Doccheck: warning about missing </span> before <h2> #22844

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 20, 2024

Hi all,

This pull request contains a backport of commit 054c644e from the openjdk/jdk repository.

The commit being backported was authored by Nizar Benalla on 20 Dec 2024 and was reviewed by Paul Sandoz.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346667: Doccheck: warning about missing </span> before <h2> (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22844/head:pull/22844
$ git checkout pull/22844

Update a local copy of the PR:
$ git checkout pull/22844
$ git pull https://git.openjdk.org/jdk.git pull/22844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22844

View PR using the GUI difftool:
$ git pr show -t 22844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22844.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2024

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346667: Doccheck: warning about missing </span> before <h2>

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the jdk24 branch:

  • bed0401: 8344611: Add missing classpath exception
  • 5d138cb: 8345266: java/util/concurrent/locks/StampedLock/OOMEInStampedLock.java JTREG_TEST_THREAD_FACTORY=Virtual fails with OOME
  • 63aa68a: 8346128: Comparison build fails due to difference in LabelTarget.html

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 054c644ea6ea38e54abc81e231977106d04bb69e 8346667: Doccheck: warning about missing </span> before <h2> Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla
Copy link
Member Author

/label add core-libs

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 25, 2024
@nizarbenalla
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 30, 2024

Going to push as commit ab78b04.
Since your change was applied there have been 3 commits pushed to the jdk24 branch:

  • bed0401: 8344611: Add missing classpath exception
  • 5d138cb: 8345266: java/util/concurrent/locks/StampedLock/OOMEInStampedLock.java JTREG_TEST_THREAD_FACTORY=Virtual fails with OOME
  • 63aa68a: 8346128: Comparison build fails due to difference in LabelTarget.html

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2024
@openjdk openjdk bot closed this Dec 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 30, 2024
@openjdk
Copy link

openjdk bot commented Dec 30, 2024

@nizarbenalla Pushed as commit ab78b04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants