Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test #22846

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 20, 2024

Here JDK-8333864 it has been discussed that the test TcpNoDelayNotRequired.java is not giving us much benefit these days so it could be removed.
From 8333864
"I suppose we could remove this test, and label the original issue as noreg-perf. The test does nothing but verify that its run time is below a certain threshold anyway."


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22846/head:pull/22846
$ git checkout pull/22846

Update a local copy of the PR:
$ git checkout pull/22846
$ git pull https://git.openjdk.org/jdk.git pull/22846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22846

View PR using the GUI difftool:
$ git pr show -t 22846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22846.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test

Reviewed-by: djelinski, lucy, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • c1b868d: 8346602: Remove unused macro parameters in jni.cpp
  • 43b7e9f: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java
  • 249f141: 8346737: GenShen: Generational memory pools should not report zero for maximum capacity
  • d562d3c: 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position
  • 7ba969a: 8346739: jpackage tests failed after JDK-8345259
  • b8e40b9: 8346688: GenShen: Missing metadata trigger log message
  • d2a4863: 8346690: Shenandoah: Fix log message for end of GC usage report
  • bcb1bda: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test Dec 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 20, 2024

Webrevs

Copy link
Member

@djelinski djelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2024
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
It's always good to remove stuff that potentially adds confusion instead of adding value.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable.

@MBaesken
Copy link
Member Author

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Dec 28, 2024

Going to push as commit 60e0730.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 807f6f7: 8346847: [s390x] minimal build failure
  • 6c59185: 8345757: [ASAN] clang17 report 'dprintf' macro redefined
  • 4fc445d: 8346829: Problem list com/sun/jdi/ReattachStressTest.java & ProcessAttachTest.java on Linux
  • 1a32654: 8346295: Update --release 24 symbol information for JDK 24 build 29
  • 62a4544: 8205051: Poor Performance with UseNUMA when cpu and memory nodes are misaligned
  • 68c6623: 8345840: Add missing TLS handshake messages to SSLHandshake.java
  • ed29231: 8337111: Bad HTML checker for generated documentation
  • cd15ebb: 8346477: Clarify the Java manpage in relation to the JVM's OnOutOfMemoryError flags
  • bffa77b: 8346714: [ASAN] compressedKlass.cpp reported applying non-zero offset to null pointer
  • c1b868d: 8346602: Remove unused macro parameters in jni.cpp
  • ... and 7 more: https://git.openjdk.org/jdk/compare/054c644ea6ea38e54abc81e231977106d04bb69e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 28, 2024
@openjdk openjdk bot closed this Dec 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 28, 2024
@openjdk
Copy link

openjdk bot commented Dec 28, 2024

@MBaesken Pushed as commit 60e0730.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net [email protected]
Development

Successfully merging this pull request may close these issues.

4 participants