8345259: Disallow ALL-MODULE-PATH without explicit --module-path

[jerboaa]

Clean backport of JDK-8345259 to JDK 24 which has JEP 493.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8345894 to be approved

Issues

• JDK-8345259: Disallow ALL-MODULE-PATH without explicit --module-path (Bug - P3)
• JDK-8345894: Disallow ALL-MODULE-PATH without explicit --module-path (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22849/head:pull/22849
$ git checkout pull/22849

Update a local copy of the PR:
$ git checkout pull/22849
$ git pull https://git.openjdk.org/jdk.git pull/22849/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22849

View PR using the GUI difftool:
$ git pr show -t 22849

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22849.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345259: Disallow ALL-MODULE-PATH without explicit --module-path

Reviewed-by: alanb, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the jdk24 branch:

• c3b5208: 8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache
• 860b30d: 8347047: Cleanup action passed to MemorySegment::reinterpret keeps old segment alive
• 256856a: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8
• cc7c293: 8345970: pthread_getcpuclockid related crashes in shenandoah tests
• 33971ec: 8346069: Add missing Classpath exception statements
• 4254e99: 8346847: [s390x] minimal build failure
• 05c3769: 8337111: Bad HTML checker for generated documentation
• ab78b04: 8346667: Doccheck: warning about missing before

• bed0401: 8344611: Add missing classpath exception
• 5d138cb: 8345266: java/util/concurrent/locks/StampedLock/OOMEInStampedLock.java JTREG_TEST_THREAD_FACTORY=Virtual fails with OOME
• ... and 1 more: https://git.openjdk.org/jdk/compare/f0ada9f34e2a768c0dbcb2ed4ff0fe4019fdee9c...jdk24

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jerboaa The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c23e154d)

[jerboaa]

@mlchung The JDK 24 backport to the stabilization tree. Thanks in advance for the review!

[AlanBateman]

Hold off on integrating this into jdk24 until some issues with jpackage tests are figured out, I think we have some failures in main line with tests that specify ALL-MODULE-PATH without a module path.

[mlchung]

I created https://bugs.openjdk.org/browse/JDK-8345259. Looks like the tests need update.

[jerboaa]

I think the bug you mean @mlchung is https://bugs.openjdk.org/browse/JDK-8346739, right? Would it be OK to get both into the jdk24 branch?

[mlchung]

I think the bug you mean @mlchung is https://bugs.openjdk.org/browse/JDK-8346739, right?

Yes. I put the wrong link.

Would it be OK to get both into the jdk24 branch?

Ok with me.

[jerboaa]

@AlanBateman @mlchung RDP2 is on January 16 for JDK 24, so about a week time. AFAIK, both fixes are eligible still. This and #22972 together should be safe. OK?

[jerboaa]

Thanks for the review. I'll wait until #22972 is reviewed and ready as well so as to make the window with test failures as small as possible.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 7d4fa78.
Since your change was applied there have been 14 commits pushed to the jdk24 branch:

• c033806: 8346739: jpackage tests failed after JDK-8345259
• bf45128: 8346872: tools/jpackage/windows/WinLongPathTest.java fails
• 29c6bf2: 8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries"
• c3b5208: 8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache
• 860b30d: 8347047: Cleanup action passed to MemorySegment::reinterpret keeps old segment alive
• 256856a: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8
• cc7c293: 8345970: pthread_getcpuclockid related crashes in shenandoah tests
• 33971ec: 8346069: Add missing Classpath exception statements
• 4254e99: 8346847: [s390x] minimal build failure
• 05c3769: 8337111: Bad HTML checker for generated documentation
• ... and 4 more: https://git.openjdk.org/jdk/compare/f0ada9f34e2a768c0dbcb2ed4ff0fe4019fdee9c...jdk24

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 7d4fa78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.