8341833: incomplete snippet from loaded files from command line is ignored #22850
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If JShell is run with a parameter that is a file, and the file ends with an incomplete snippet, the incomplete snippet is ignored.
For example:
This PR proposes to produce an explicit error in this case:
Progress
Warning
8341833: incomplete snippet from loaded files from command line is ignored
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22850/head:pull/22850
$ git checkout pull/22850
Update a local copy of the PR:
$ git checkout pull/22850
$ git pull https://git.openjdk.org/jdk.git pull/22850/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22850
View PR using the GUI difftool:
$ git pr show -t 22850
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22850.diff
Using Webrev
Link to Webrev Comment