Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341833: incomplete snippet from loaded files from command line is ignored #22850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Dec 20, 2024

If JShell is run with a parameter that is a file, and the file ends with an incomplete snippet, the incomplete snippet is ignored.

For example:

t.jsh:
class {
 jshell  /tmp/t.jsh
|  Welcome to JShell -- Version 21.0.5
|  For an introduction type: /help intro

jshell>

This PR proposes to produce an explicit error in this case:

$ jshell /tmp/t.jsh 
Building target 'default (exploded-image)' in configuration 'linux-x86_64-server-release'
Finished building target 'default (exploded-image)' in configuration 'linux-x86_64-server-release'
Incomplete input: class {
|  Welcome to JShell -- Version 25-internal
|  For an introduction type: /help intro

jshell>

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8341833: incomplete snippet from loaded files from command line is ignored

Issue

  • JDK-8341833: incomplete snippet from loaded files from command line is ignored (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22850/head:pull/22850
$ git checkout pull/22850

Update a local copy of the PR:
$ git checkout pull/22850
$ git pull https://git.openjdk.org/jdk.git pull/22850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22850

View PR using the GUI difftool:
$ git pr show -t 22850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22850.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2024

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 20, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kulla [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant