8346773: Fix unmatched brackets in source files #22861
Conversation
|
👋 Welcome back qxing! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@MaxXSoft The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
| @@ -172,7 +172,7 @@ Provide informative, but not too verbose error messages. | |||
| All GoogleTest asserts print compared expressions and their values, so | |||
| there is no need to have them in error messages. Asserts print only | |||
| compared values, they do not print any of interim variables, e.g. | |||
| `ASSERT_TRUE((val1 == val2 && isFail(foo(8)) || i == 18)` prints only | |||
| `ASSERT_TRUE(val1 == val2 && isFail(foo(8)) || i == 18)` prints only | |||
There was a problem hiding this comment.
Looking at this expression, I believe the intention is this.
| `ASSERT_TRUE(val1 == val2 && isFail(foo(8)) || i == 18)` prints only | |
| `ASSERT_TRUE((val1 == val2 && isFail(foo(8))) || i == 18)` prints only |
| @@ -1082,7 +1082,7 @@ Warnings: All cp values have U+FE0F characters removed. See /annotationsDerived/ | |||
| <type key="calendar" type="indian">ಭಾರತೀಯ ರಾಷ್ಟ್ರೀಯ ಕ್ಯಾಲೆಂಡರ್</type> | |||
| <type key="calendar" type="islamic">ಇಸ್ಲಾಮಿಕ್ ಕ್ಯಾಲೆಂಡರ್</type> | |||
| <type key="calendar" type="islamic-civil">ಇಸ್ಲಾಮಿಕ್-ಸಿವಿಲ್ ಕ್ಯಾಲೆಂಡರ್</type> | |||
| <type key="calendar" type="islamic-rgsa" draft="contributed">ಇಸ್ಲಾಮಿಕ್ ಕ್ಯಾಲೆಂಡರ್ (ಸೌದಿ ಅರೇಬಿಯಾ, ಸೈಟಿಂಗ್)bia, sighting)</type> | |||
| <type key="calendar" type="islamic-rgsa" draft="contributed">ಇಸ್ಲಾಮಿಕ್ ಕ್ಯಾಲೆಂಡರ್ (ಸೌದಿ ಅರೇಬಿಯಾ, ಸೈಟಿಂಗ್)</type> | |||
There was a problem hiding this comment.
Hi, we would not modify the contents of upstream data from CLDR.
This patch fixes unmatched brackets in some source files.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22861/head:pull/22861$ git checkout pull/22861Update a local copy of the PR:
$ git checkout pull/22861$ git pull https://git.openjdk.org/jdk.git pull/22861/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22861View PR using the GUI difftool:
$ git pr show -t 22861Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22861.diff
Using Webrev
Link to Webrev Comment