Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341611: [REDO] AArch64: Clean up IndOffXX type and let legitimize_address() fix out-of-range operands #22862

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fg1417
Copy link

@fg1417 fg1417 commented Dec 23, 2024

IndOffXX types don't do us any good. It would be simpler and faster to match a general-purpose IndOff type then let legitimize_address() fix any out-of-range operands. That'd reduce the size of the match rules and the time to run them.

This patch simplifies the definitions of immXOffset with an estimated range. Whether an immediate can be encoded in a LDR/STR instructions as an offset will be determined in the phase of code-emitting. Meanwhile, we add necessary legitimize_address() in the phase of matcher for all LDR/STR instructions using the new IndOff memory operands (fix JDK-8341437).

After this clean-up, memory operands matched with IndOff may require extra code emission (effectively a lea) before the address can be used. So we also modify the code about looking up precise offset of load/store instruction for implicit null check (fix JDK-8340646). On aarch64 platform, we will use the beginning offset of the last instruction in the instruction clause emitted for a load/store machine node. Because LDR/STR is always the last one emitted, no matter what addressing mode the load/store operations finally use.

Tier 1 - 3 passed on Macos-aarch64 with or without the vm option -XX:+UseZGC.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341611: [REDO] AArch64: Clean up IndOffXX type and let legitimize_address() fix out-of-range operands (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22862/head:pull/22862
$ git checkout pull/22862

Update a local copy of the PR:
$ git checkout pull/22862
$ git pull https://git.openjdk.org/jdk.git pull/22862/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22862

View PR using the GUI difftool:
$ git pr show -t 22862

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22862.diff

Using Webrev

Link to Webrev Comment

…dress() fix out-of-range operands

IndOffXX types don't do us any good. It would be simpler and
faster to match a general-purpose IndOff type then let
legitimize_address() fix any out-of-range operands. That'd
reduce the size of the match rules and the time to run them.

This patch simplifies the definitions of `immXOffset` with an
estimated range. Whether an immediate can be encoded in a
LDR/STR instructions as an offset will be determined in the phase
of code-emitting. Meanwhile, we add necessary
`legitimize_address()` in the phase of matcher for all LDR/STR
instructions using the new `IndOff` memory operands
(fix JDK-8341437).

After this clean-up, memory operands matched with `IndOff` may
require extra code emission (effectively a lea) before the address
can be used. So we also modify the code about looking up precise
offset of load/store instruction for implicit null check
(fix JDK-8340646). On aarch64 platform, we will use the beginning
offset of the last instruction in the instruction clause emitted
for a load/store machine node. Because LDR/STR is always the last
one emitted, no matter what addressing mode the load/store
operations finally use.

Tier 1 - 3 passed on Macos-aarch64 with or without the vm option
"-XX:+UseZGC"
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back fgao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@fg1417 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant