8365379: SU3.applyInsets may produce wrong results

[Renjithkannath]

Hi Reviewers,

I have updated the insets calculation, similar calculation observed in SynthGraphicsUtils.java. Reused the SwingUtilities3.java modified code

Please review and let me know your suggestions if any.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365379: SU3.applyInsets may produce wrong results (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27157/head:pull/27157
$ git checkout pull/27157

Update a local copy of the PR:
$ git checkout pull/27157
$ git pull https://git.openjdk.org/jdk.git pull/27157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27157

View PR using the GUI difftool:
$ git pr show -t 27157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27157.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@Renjithkannath The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (4d4a2a5a)
• 04: Full - Incremental (6fca8bcd)
• 03: Full - Incremental (da742883)
• 02: Full - Incremental (955297b1)
• 01: Full - Incremental (fae0e8ee)
• 00: Full (5638737d)

[mrserb]

Can this change covered by the new test?

[Renjithkannath]

Thank you @mrserb for the valuable suggestion. I have added a verification test for this case.

[openjdk]

⚠️ @Renjithkannath This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[mrserb]

Can we verify it w/o using internals?

[Renjithkannath]

As you are aware existing calculation will go wrong only for non zero X & Y. As far as my understanding existing calls passing 0,0 as X,Y. so I did not find any other way w/o using internals.

FYI : summary was wrong that I have corrected.

Let me know if you have any suggestions.