8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing #27161

azvegint · 2025-09-09T06:28:08Z

There are several major issues with the test:

The frameExited variable is set to true when the mouse pointer exits the frame. The test does not expect this to happen with the first mouse click on the choice when the mouse pointer is already over the test frame (frame mouseExited - > choice mouseEntered). A reset for the frameExited was added.
The test does not wait for the frame to appear after the call to setVisible(), so the test can start operating not on a fully visible window (e.g. one with an appearance animation). A delay has been added.
In macOS, the direction of rotation of the mouse wheel is different, which was not taken into account.

Testing looks good.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing (Bug - P4)

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer)
Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27161/head:pull/27161
$ git checkout pull/27161

Update a local copy of the PR:
$ git checkout pull/27161
$ git pull https://git.openjdk.org/jdk.git pull/27161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27161

View PR using the GUI difftool:
$ git pr show -t 27161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27161.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-09T06:29:55Z

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-09T06:30:46Z

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing

Reviewed-by: psadhukhan, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

850f904: 8367451: GenShen: Remove the option to compute age census during evacuation
11df289: 8367378: GenShen: Missing timing stats when old mark buffers are flushed during final update refs
aeffce7: 8367271: Add parsing tests to DateFormat JMH benchmark
... and 86 more: https://git.openjdk.org/jdk/compare/bcff857ba09028cc43e856726b5c839cc6b1b0d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-09-09T06:32:05Z

@azvegint The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-09-09T06:35:23Z

Webrevs

01: Full - Incremental (f7c9bc09)
00: Full (e6d3846f)

prsadhuk · 2025-09-10T07:35:57Z

test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java

-                    throw new RuntimeException("Mouse Wheel over the choice failed!");
-                }
+        // mouse wheel doesn't work for the choice on X11 and Mac, so skip it
+        if (!isXtoolkit && !isLWCToolkit) {


Is this block required? As in the description it is mentioned that the wheel rotation is taken care for macos down below and it seems test works ok without this block too..

This is a different case that only works on Windows. When the mouse cursor is above the choice, you should be able to change the items using the mouse wheel (without click and showing a popup)

prsadhuk · 2025-09-10T07:36:12Z

test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java

-    public static void main(String[] args) {
-        new ChoiceMouseWheelTest();
+    public static void main(String[] args) throws Exception {
+        ChoiceMouseWheelTest test = Util.invokeOnEDT(ChoiceMouseWheelTest::new);


Is there any need to have dependancy on Util..we can use EventQueue directly, right? That will help in running standalone too!!

Also jtreg tags is not aligned with asterisks and author tag not removed||

Is there any need to have dependancy on Util..we can use EventQueue directly, right? That will help in running standalone too!!

It was already there, so I decided to use it. It greatly reduce the code amount.

Also jtreg tags is not aligned with asterisks and author tag not removed||

updated

prsadhuk · 2025-09-11T05:17:16Z

test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java


 public class ChoiceMouseWheelTest extends Frame {

    private volatile boolean itemChanged = false;
    private volatile boolean wheelMoved = false;
    private volatile boolean frameExited = false;
+    private final Choice choice = new Choice();


WHy not do the initialization in EDT in constructor?

It is already on EDT, but moved to the constructor.

honkar-jdk

Changes LGTM.

honkar-jdk · 2025-09-12T18:54:40Z

test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java

+ * @test
+ * @key headful
+ * @bug 7050935
+ * @summary closed/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.html fails on win32


Minor: You may want to change the test path in the summary

azvegint added 4 commits September 9, 2025 07:39

actual fix

f4b62b2

cleanup

d1f85d4

fix enter drop-down condition

8e1d43f

remove System.exit()

e6d3846

openjdk bot added client [email protected] rfr Pull request is ready for review labels Sep 9, 2025

prsadhuk reviewed Sep 11, 2025

View reviewed changes

review comments

f7c9bc0

prsadhuk approved these changes Sep 12, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2025

honkar-jdk approved these changes Sep 12, 2025

View reviewed changes

honkar-jdk reviewed Sep 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing #27161

8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing #27161

azvegint commented Sep 9, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 9, 2025

Uh oh!

openjdk bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Sep 9, 2025

Uh oh!

mlbridge bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

prsadhuk Sep 10, 2025

Uh oh!

azvegint Sep 11, 2025 •

edited

Loading

Uh oh!

prsadhuk Sep 10, 2025

Uh oh!

azvegint Sep 11, 2025

Uh oh!

prsadhuk Sep 11, 2025

Uh oh!

azvegint Sep 11, 2025

Uh oh!

honkar-jdk left a comment

Uh oh!

honkar-jdk Sep 12, 2025

Uh oh!

Uh oh!

8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing #27161

Are you sure you want to change the base?

8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing #27161

Conversation

azvegint commented Sep 9, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 9, 2025

Uh oh!

openjdk bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 9, 2025

Uh oh!

mlbridge bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

prsadhuk Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

azvegint Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prsadhuk Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

azvegint Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

azvegint Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azvegint commented Sep 9, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 9, 2025 •

edited

Loading

mlbridge bot commented Sep 9, 2025 •

edited

Loading

azvegint Sep 11, 2025 •

edited

Loading