8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button #27162
Conversation
…r platform except linux.
|
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
|
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 117 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
| This test is for verifying Alt-Gr modifier of an event. | ||
| Please check if Alt-Gr key is present on keyboard. | ||
| If not present, press Pass. | ||
| Window :- |
There was a problem hiding this comment.
| Window :- | |
| On Windows: |
There should be no space before colon… in English punctuation.
| Window :- | ||
| Press Alt-Gr or Right Alt key and simulataneously | ||
| perform mouse click on the "TestWindow". | ||
| Linux :- |
There was a problem hiding this comment.
| Linux :- | |
| On Linux: |
| perform mouse click on the "TestWindow". | ||
| Linux :- | ||
| Navigate to | ||
| System Settings-> Keyboard-> Shortcuts->Typing. |
There was a problem hiding this comment.
| System Settings-> Keyboard-> Shortcuts->Typing. | |
| System Settings-> Keyboard-> Shortcuts-> Typing. |
Be consistent.
| Navigate to | ||
| System Settings-> Keyboard-> Shortcuts->Typing. | ||
| Select an option for the Alternative Characters Key | ||
| For example. Right Alt |
There was a problem hiding this comment.
The instructions are still unclear to me. There's no Shortcut settings in GNOME in Ubuntu 22.04.
There is, however, Keyboard Shortcuts section with View and customise shortcuts. In the popup, there's a Typing section, but there's nothing like alternative keys.
On the main Keyboard settings screen, there's an option Alternate Characters Key, it's set to Layout default in my settings. Is this the option to change?
The original instructions make the tester click twice: before changing an option in the settings and after doing so. The new instructions ask to change the setting only.
There was a problem hiding this comment.
On the main Keyboard settings screen, there's an option Alternate Characters Key, it's set to Layout default in my settings. Is this the option to change?
Yes, I modified the instruction
| @Override | ||
| public void mousePressed(MouseEvent e) { |
There was a problem hiding this comment.
| @Override | |
| public void mousePressed(MouseEvent e) { | |
| @Override | |
| public void mousePressed(MouseEvent e) { |
Correct the indentation.
prsadhuk
changed the title
prsadhuk
changed the title
prsadhuk
changed the title
| Please check if Alt-Gr key is present on keyboard. | ||
| If not present, press Pass. | ||
| On Windows: | ||
| Press Alt-Gr or Right Alt key and simulataneously |
There was a problem hiding this comment.
| Press Alt-Gr or Right Alt key and simulataneously | |
| Press Alt-Gr or Right Alt key and simultaneously |
| On Linux: | ||
| Navigate to | ||
| System Settings-> Keyboard-> Special Character Entry | ||
| Select "Right Alt" option for the "Alternative Characters Key" |
There was a problem hiding this comment.
| Select "Right Alt" option for the "Alternative Characters Key" | |
| Select "Right Alt" option for the "Alternate Characters Key" |
I guess we should add instructions for a test user to turn the setting back to default, or skip the test if their system does not have such a setting.
We also use the forcePass/forceFail approach:
- The test user may not have a chance to read the instructions all the way through if they are just following them.
- If the user accidentally presses a mouse button with the wrong or missing modifier, there is no way to retry.
So maybe we should add logArea and print theresults there, to allow the test user to make several attempts, and read the instructions till the end.
There was a problem hiding this comment.
Usually user should read the instructions till the end and then only attempt the test, which is true for all the manual tests
but I got the point.
I have added logArea and let user press Pass/Fail depending on the result printed there..
There was a problem hiding this comment.
What do you think about the following?
I guess we should add instructions for a test user to turn the setting back to default, or skip the test if their system does not have such a setting.
There was a problem hiding this comment.
Usually it's implicit to change the setting back to original but I have added the instructions just in case..
|
/integrate |
|
Going to push as commit 34c3ac0.
Your commit was automatically rebased without conflicts. |
Test was made to fail due to presence of only "Fail" button instead of both "Pass" and "Fail".
Modified the test to use PFJ and also clarified the instruction for Windows and Linux
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27162/head:pull/27162$ git checkout pull/27162Update a local copy of the PR:
$ git checkout pull/27162$ git pull https://git.openjdk.org/jdk.git pull/27162/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27162View PR using the GUI difftool:
$ git pr show -t 27162Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27162.diff
Using Webrev
Link to Webrev Comment